Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: chrome/test/data/webui/settings/settings_ui_browsertest.js

Issue 2469393004: MD Settings: Preserve search URL param in subpages. (Closed)
Patch Set: Function params nit. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/data/webui/settings/settings_menu_test.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for the Settings layout. */ 5 /** @fileoverview Suite of tests for the Settings layout. */
6 6
7 GEN_INCLUDE(['settings_page_browsertest.js']); 7 GEN_INCLUDE(['settings_page_browsertest.js']);
8 8
9 /** 9 /**
10 * @constructor 10 * @constructor
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // Check that all values are updated in unison. 109 // Check that all values are updated in unison.
110 assertFalse(menu.advancedOpened); 110 assertFalse(menu.advancedOpened);
111 assertFalse(ui.advancedOpened_); 111 assertFalse(ui.advancedOpened_);
112 assertFalse(main.advancedToggleExpanded); 112 assertFalse(main.advancedToggleExpanded);
113 }); 113 });
114 114
115 test('URL initiated search propagates to search box', function() { 115 test('URL initiated search propagates to search box', function() {
116 toolbar = /** @type {!CrToolbarElement} */ (ui.$$('cr-toolbar')); 116 toolbar = /** @type {!CrToolbarElement} */ (ui.$$('cr-toolbar'));
117 var searchField = /** @type {CrToolbarSearchFieldElement} */ ( 117 var searchField = /** @type {CrToolbarSearchFieldElement} */ (
118 toolbar.getSearchField()); 118 toolbar.getSearchField());
119 assertEquals('', searchField.getSearchInput().bindValue);
119 120
120 var query = 'foo'; 121 var query = 'foo';
121 settings.navigateTo( 122 settings.navigateTo(
122 settings.Route.BASIC, new URLSearchParams(`search=${query}`)); 123 settings.Route.BASIC, new URLSearchParams(`search=${query}`));
123 assertEquals(query, searchField.getSearchInput().bindValue); 124 assertEquals(query, searchField.getSearchInput().bindValue);
124
125 settings.navigateTo(settings.Route.BASIC);
126 assertEquals('', searchField.getSearchInput().bindValue);
127 }); 125 });
128 126
129 test('search box initiated search propagates to URL', function() { 127 test('search box initiated search propagates to URL', function() {
130 assertFalse(settings.getQueryParameters().has('search'));
131 var searchField = /** @type {CrToolbarSearchFieldElement} */ ( 128 var searchField = /** @type {CrToolbarSearchFieldElement} */ (
132 toolbar.getSearchField()); 129 toolbar.getSearchField());
130
131 settings.navigateTo(
132 settings.Route.BASIC, /* dynamicParams */ null,
133 /* removeSearch */ true);
134 assertEquals('', searchField.getSearchInput().bindValue);
135 assertFalse(settings.getQueryParameters().has('search'));
136
133 var value = 'GOOG'; 137 var value = 'GOOG';
134 searchField.setValue(value); 138 searchField.setValue(value);
135 assertEquals(value, settings.getQueryParameters().get('search')); 139 assertEquals(value, settings.getQueryParameters().get('search'));
136 }); 140 });
137 141
138 test('whitespace only search query is ignored', function() { 142 test('whitespace only search query is ignored', function() {
139 toolbar = /** @type {!CrToolbarElement} */ (ui.$$('cr-toolbar')); 143 toolbar = /** @type {!CrToolbarElement} */ (ui.$$('cr-toolbar'));
140 var searchField = /** @type {CrToolbarSearchFieldElement} */ ( 144 var searchField = /** @type {CrToolbarSearchFieldElement} */ (
141 toolbar.getSearchField()); 145 toolbar.getSearchField());
142 searchField.setValue(' '); 146 searchField.setValue(' ');
143 var urlParams = settings.getQueryParameters(); 147 var urlParams = settings.getQueryParameters();
144 assertFalse(urlParams.has('search')); 148 assertFalse(urlParams.has('search'));
145 149
146 searchField.setValue(' foo'); 150 searchField.setValue(' foo');
147 urlParams = settings.getQueryParameters(); 151 urlParams = settings.getQueryParameters();
148 assertEquals('foo', urlParams.get('search')); 152 assertEquals('foo', urlParams.get('search'));
149 153
150 searchField.setValue(' foo '); 154 searchField.setValue(' foo ');
151 urlParams = settings.getQueryParameters(); 155 urlParams = settings.getQueryParameters();
152 assertEquals('foo ', urlParams.get('search')); 156 assertEquals('foo ', urlParams.get('search'));
153 157
154 searchField.setValue(' '); 158 searchField.setValue(' ');
155 urlParams = settings.getQueryParameters(); 159 urlParams = settings.getQueryParameters();
156 assertFalse(urlParams.has('search')); 160 assertFalse(urlParams.has('search'));
157 }); 161 });
158 }); 162 });
159 163
160 mocha.run(); 164 mocha.run();
161 }); 165 });
OLDNEW
« no previous file with comments | « chrome/test/data/webui/settings/settings_menu_test.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698