Android accessibility: skip the root element when it has no title

Android accessibility: skip the root element when it has no title

By default when a node is focusable it's always interesting (meaning we
always land on it in sequential navigation) and we try to get its text
from contents if it doesn't have a name (so that something is announced
when you land on it). Make an exception for the root element, because
landing on a WebView and having it read the entire text is too verbose
and confusing.

BUG=660090
Committed: https://crrev.com/cf18133784e2e5d324c09b99a6b142874e609364
Cr-Commit-Position: refs/heads/master@{#432621}

[dmazzoni, 2016-11-02 18:48:54]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2016-11-02 19:33:38]

This seems like a round about fix. Why not just make webviews without a title
return their url?

[David Tseng, 2016-11-02 19:36:10]

On 2016/11/02 19:33:38, David Tseng wrote:
> This seems like a round about fix. Why not just make webviews without a title
> return their url?

Alternatively, I would just skip landing on an embedded webview (inside of an
app). Talkback should be reading the ancestry change itself if it chooses to.

When outside of a webview (inside of Chrome), I think we should land on the root
and return the title ||url.

[chromium-reviews, 2016-11-02 19:47:28]

I happened to see this patch and I have a comment. Feel free to ignore 
it if I haven't understood this fully.
If we return the URL wouldn't we have two potential issues?
1. The app that is embedding the WebView might not want the URL to be 
exposed. Or, the app that might have started Chrome through an intent 
might want to hide the URL from the user. Is there a way to hide the 
address bar?
2. The URL might be confusing or complicated. I remember Jaws reading 
long URLs for images without alt text. The URLs are made up of many 
letters and numbers.
Why not return the page title if present, otherwise the empty string?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-11-02 19:55:47]

For an embedded WebView I see no reason to announce the url. Usually that's
intended to be an implementation detail, and the user can't navigate it or
anything.

For the Chrome browser, I feel like the url is redundant there too, since
the address bar is on the screen. The only difference is that here I feel
TalkBack ought to announce the role like WebView no matter what.


On Wed, Nov 2, 2016 at 12:47 PM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> I happened to see this patch and I have a comment. Feel free to ignore
> it if I haven't understood this fully.
> If we return the URL wouldn't we have two potential issues?
> 1. The app that is embedding the WebView might not want the URL to be
> exposed. Or, the app that might have started Chrome through an intent
> might want to hide the URL from the user. Is there a way to hide the
> address bar?
> 2. The URL might be confusing or complicated. I remember Jaws reading
> long URLs for images without alt text. The URLs are made up of many
> letters and numbers.
> Why not return the page title if present, otherwise the empty string?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2016-11-02 21:47:41]

lgtm

[David Tseng, 2016-11-02 22:07:30]

On Wed, Nov 2, 2016 at 12:47 PM, 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> I happened to see this patch and I have a comment. Feel free to ignore it
> if I haven't understood this fully.
> If we return the URL wouldn't we have two potential issues?
> 1. The app that is embedding the WebView might not want the URL to be
> exposed. Or, the app that might have started Chrome through an intent might
> want to hide the URL from the user. Is there a way to hide the address bar?
> 2. The URL might be confusing or complicated. I remember Jaws reading long
> URLs for images without alt text. The URLs are made up of many letters and
> numbers.
> Why not return the page title if present, otherwise the empty string?
>
>
> To summarize the offline discussion:
> Talkback should be responsible for whether it announces the root, or even
lands on the root via linear navigation. Thus, it could in theory skip roots for
embedded webviews and only land on the root while inside of Chrome. For the
former, a sighted user doesn't actually see the title, so this would be
unintended noise I think in most cases. It should behave more like a frame and
the app should "feel" native.
>
>

> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-11-07 08:33:24]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-11-07 08:33:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 09:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 09:44:51]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmazzoni, 2016-11-14 23:18:40]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 23:19:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:38:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmazzoni, 2016-11-16 18:28:43]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-11-16 18:28:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2469383002/#ps20001
(title: "Fix two test expectations")

[commit-bot: I haz the power, 2016-11-16 18:29:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 20:49:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 21:00:15]

Description was changed from

==========
Android accessibility: skip the root element when it has no title

By default when a node is focusable it's always interesting (meaning we
always land on it in sequential navigation) and we try to get its text
from contents if it doesn't have a name (so that something is announced
when you land on it). Make an exception for the root element, because
landing on a WebView and having it read the entire text is too verbose
and confusing.

BUG=660090
==========

to

==========
Android accessibility: skip the root element when it has no title

By default when a node is focusable it's always interesting (meaning we
always land on it in sequential navigation) and we try to get its text
from contents if it doesn't have a name (so that something is announced
when you land on it). Make an exception for the root element, because
landing on a WebView and having it read the entire text is too verbose
and confusing.

BUG=660090

Committed: https://crrev.com/cf18133784e2e5d324c09b99a6b142874e609364
Cr-Commit-Position: refs/heads/master@{#432621}
==========

[commit-bot: I haz the power, 2016-11-16 21:00:16]

Patchset 2 (id:??) landed as
https://crrev.com/cf18133784e2e5d324c09b99a6b142874e609364
Cr-Commit-Position: refs/heads/master@{#432621}