Tech Debt Repayment for StartupBrowserCreatorImpl Refactor

chrome/browser/ui/startup/startup_tab_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_PROVIDER_H_
 #define CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_PROVIDER_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
@@ skipping 36 matching lines @@
   // Returns the New Tab Page, if the user's preferences indicate a
   // configuration where it must be passed explicitly.
   virtual StartupTabs GetNewTabPageTabs(const base::CommandLine& command_line,
                                         Profile* profile) const = 0;
 };
 
 class StartupTabProviderImpl : public StartupTabProvider {
  public:
   StartupTabProviderImpl() = default;
 
-  // The static Check*TabPolicy methods below enforce the policies relevant to
-  // the respective Get*Tabs methods, but do not gather or interact with any
-  // system state relating to making those policy decisions.
+  // The static helper methods below implement the policies relevant to the
+  // respective Get*Tabs methods, but do not gather or interact with any
+  // system state relating to making those policy decisions. Exposed for
+  // testing.
 
   // Determines which tabs should be shown according to onboarding/first
   // run policy.
-  static StartupTabs CheckStandardOnboardingTabPolicy(
+  static StartupTabs GetStandardOnboardingTabsForState(
       bool is_first_run,
       bool has_seen_welcome_page,
       bool is_signed_in,
       bool is_supervised_user);
 
 #if defined(OS_WIN)
   // Determines which tabs should be shown according to onboarding/first run
   // policy, including promo content specific to Windows 10.
-  static StartupTabs CheckWin10OnboardingTabPolicy(
+  static StartupTabs GetWin10OnboardingTabsForState(
       bool is_first_run,
       bool has_seen_welcome_page,
       bool has_seen_win10_promo,
       bool is_signed_in,
       bool set_default_browser_allowed,
       bool is_default_browser,
       bool is_supervised_user);
 #endif
 
   // Processes first run URLs specified in Master Preferences file, replacing
   // any "magic word" URL hosts with appropriate URLs.
-  static StartupTabs CheckMasterPrefsTabPolicy(
+  static StartupTabs GetMasterPrefsTabsForState(
       bool is_first_run,
       const std::vector<GURL>& first_run_tabs);
 
   // Determines which tabs should be shown as a result of the presence/absence
   // of a Reset Trigger on this profile.
-  static StartupTabs CheckResetTriggerTabPolicy(bool profile_has_trigger);
+  static StartupTabs GetResetTriggerTabsForState(bool profile_has_trigger);
 
   // Determines whether the startup preference requires the contents of
   // |pinned_tabs| to be shown. This is needed to avoid duplicates, as the
   // session restore logic will also resurface pinned tabs on its own.
-  static StartupTabs CheckPinnedTabPolicy(const SessionStartupPref& pref,
-                                          const StartupTabs& pinned_tabs);
+  static StartupTabs GetPinnedTabsForState(const SessionStartupPref& pref,
+                                           const StartupTabs& pinned_tabs);
 
   // Determines whether preferences and window state indicate that
   // user-specified tabs should be shown as the default new window content, and
   // returns the specified tabs if so.
-  static StartupTabs CheckPreferencesTabPolicy(
+  static StartupTabs GetPreferencesTabsForState(
       const SessionStartupPref& pref,
       bool profile_has_other_tabbed_browser);
 
   // Determines whether startup preferences require the New Tab Page to be
   // explicitly specified. Session Restore does not expect the NTP to be passed.
-  static StartupTabs CheckNewTabPageTabPolicy(const SessionStartupPref& pref);
+  static StartupTabs GetNewTabPageTabsForState(const SessionStartupPref& pref);
 
   // Gets the URL for the Welcome page. If |use_later_run_variant| is true, a
   // URL parameter will be appended so as to access the variant page used when
   // onboarding occurs after the first Chrome execution (e.g., when creating an
   // additional profile).
   static GURL GetWelcomePageUrl(bool use_later_run_variant);
 
 #if defined(OS_WIN)
   // Gets the URL for the Windows 10 Welcome page. If |use_later_run_variant| is
   // true, a URL parameter will be appended so as to access the variant page
@@ skipping 15 matching lines @@
   StartupTabs GetPreferencesTabs(const base::CommandLine& command_line,
                                  Profile* profile) const override;
   StartupTabs GetNewTabPageTabs(const base::CommandLine& command_line,
                                 Profile* profile) const override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(StartupTabProviderImpl);
 };
 
 #endif  // CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_PROVIDER_H_