Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 2469353003: Skip base::string16 if not necessary for WebString <-> ASCII conversion (Closed)
Patch Set: minor fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 932 matching lines...) Expand 10 before | Expand all | Expand 10 after
943 SetCursiveFontFamilyWrapper, settings); 943 SetCursiveFontFamilyWrapper, settings);
944 ApplyFontsFromMap(prefs.fantasy_font_family_map, 944 ApplyFontsFromMap(prefs.fantasy_font_family_map,
945 SetFantasyFontFamilyWrapper, settings); 945 SetFantasyFontFamilyWrapper, settings);
946 ApplyFontsFromMap(prefs.pictograph_font_family_map, 946 ApplyFontsFromMap(prefs.pictograph_font_family_map,
947 SetPictographFontFamilyWrapper, settings); 947 SetPictographFontFamilyWrapper, settings);
948 settings->setDefaultFontSize(prefs.default_font_size); 948 settings->setDefaultFontSize(prefs.default_font_size);
949 settings->setDefaultFixedFontSize(prefs.default_fixed_font_size); 949 settings->setDefaultFixedFontSize(prefs.default_fixed_font_size);
950 settings->setMinimumFontSize(prefs.minimum_font_size); 950 settings->setMinimumFontSize(prefs.minimum_font_size);
951 settings->setMinimumLogicalFontSize(prefs.minimum_logical_font_size); 951 settings->setMinimumLogicalFontSize(prefs.minimum_logical_font_size);
952 settings->setDefaultTextEncodingName( 952 settings->setDefaultTextEncodingName(
953 base::ASCIIToUTF16(prefs.default_encoding)); 953 WebString::fromASCII(prefs.default_encoding));
954 settings->setJavaScriptEnabled(prefs.javascript_enabled); 954 settings->setJavaScriptEnabled(prefs.javascript_enabled);
955 settings->setWebSecurityEnabled(prefs.web_security_enabled); 955 settings->setWebSecurityEnabled(prefs.web_security_enabled);
956 settings->setJavaScriptCanOpenWindowsAutomatically( 956 settings->setJavaScriptCanOpenWindowsAutomatically(
957 prefs.javascript_can_open_windows_automatically); 957 prefs.javascript_can_open_windows_automatically);
958 settings->setLoadsImagesAutomatically(prefs.loads_images_automatically); 958 settings->setLoadsImagesAutomatically(prefs.loads_images_automatically);
959 settings->setImagesEnabled(prefs.images_enabled); 959 settings->setImagesEnabled(prefs.images_enabled);
960 settings->setPluginsEnabled(prefs.plugins_enabled); 960 settings->setPluginsEnabled(prefs.plugins_enabled);
961 settings->setDOMPasteAllowed(prefs.dom_paste_enabled); 961 settings->setDOMPasteAllowed(prefs.dom_paste_enabled);
962 settings->setTextAreasAreResizable(prefs.text_areas_are_resizable); 962 settings->setTextAreasAreResizable(prefs.text_areas_are_resizable);
963 settings->setAllowScriptsToCloseWindows(prefs.allow_scripts_to_close_windows); 963 settings->setAllowScriptsToCloseWindows(prefs.allow_scripts_to_close_windows);
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 settings->setAccessibilityFontScaleFactor(prefs.font_scale_factor); 1105 settings->setAccessibilityFontScaleFactor(prefs.font_scale_factor);
1106 settings->setDeviceScaleAdjustment(prefs.device_scale_adjustment); 1106 settings->setDeviceScaleAdjustment(prefs.device_scale_adjustment);
1107 settings->setFullscreenSupported(prefs.fullscreen_supported); 1107 settings->setFullscreenSupported(prefs.fullscreen_supported);
1108 web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom); 1108 web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom);
1109 settings->setAutoZoomFocusedNodeToLegibleScale(true); 1109 settings->setAutoZoomFocusedNodeToLegibleScale(true);
1110 settings->setDoubleTapToZoomEnabled(prefs.double_tap_to_zoom_enabled); 1110 settings->setDoubleTapToZoomEnabled(prefs.double_tap_to_zoom_enabled);
1111 settings->setMediaControlsOverlayPlayButtonEnabled(true); 1111 settings->setMediaControlsOverlayPlayButtonEnabled(true);
1112 settings->setMediaPlaybackRequiresUserGesture( 1112 settings->setMediaPlaybackRequiresUserGesture(
1113 prefs.user_gesture_required_for_media_playback); 1113 prefs.user_gesture_required_for_media_playback);
1114 settings->setDefaultVideoPosterURL( 1114 settings->setDefaultVideoPosterURL(
1115 base::ASCIIToUTF16(prefs.default_video_poster_url.spec())); 1115 WebString::fromASCII(prefs.default_video_poster_url.spec()));
1116 settings->setSupportDeprecatedTargetDensityDPI( 1116 settings->setSupportDeprecatedTargetDensityDPI(
1117 prefs.support_deprecated_target_density_dpi); 1117 prefs.support_deprecated_target_density_dpi);
1118 settings->setUseLegacyBackgroundSizeShorthandBehavior( 1118 settings->setUseLegacyBackgroundSizeShorthandBehavior(
1119 prefs.use_legacy_background_size_shorthand_behavior); 1119 prefs.use_legacy_background_size_shorthand_behavior);
1120 settings->setWideViewportQuirkEnabled(prefs.wide_viewport_quirk); 1120 settings->setWideViewportQuirkEnabled(prefs.wide_viewport_quirk);
1121 settings->setUseWideViewport(prefs.use_wide_viewport); 1121 settings->setUseWideViewport(prefs.use_wide_viewport);
1122 settings->setForceZeroLayoutHeight(prefs.force_zero_layout_height); 1122 settings->setForceZeroLayoutHeight(prefs.force_zero_layout_height);
1123 settings->setViewportMetaLayoutSizeQuirk( 1123 settings->setViewportMetaLayoutSizeQuirk(
1124 prefs.viewport_meta_layout_size_quirk); 1124 prefs.viewport_meta_layout_size_quirk);
1125 settings->setViewportMetaMergeContentQuirk( 1125 settings->setViewportMetaMergeContentQuirk(
(...skipping 1914 matching lines...) Expand 10 before | Expand all | Expand 10 after
3040 NotifyInputEventHandled(input_event->type, 3040 NotifyInputEventHandled(input_event->type,
3041 INPUT_EVENT_ACK_STATE_NOT_CONSUMED); 3041 INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
3042 } 3042 }
3043 3043
3044 std::unique_ptr<InputEventAck> ack( 3044 std::unique_ptr<InputEventAck> ack(
3045 new InputEventAck(input_event->type, INPUT_EVENT_ACK_STATE_NOT_CONSUMED)); 3045 new InputEventAck(input_event->type, INPUT_EVENT_ACK_STATE_NOT_CONSUMED));
3046 OnInputEventAck(std::move(ack)); 3046 OnInputEventAck(std::move(ack));
3047 } 3047 }
3048 3048
3049 } // namespace content 3049 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/renderer_blink_platform_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698