Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: content/test/BUILD.gn

Issue 2469353002: Convert Site Isolation Win bot to --isolate-extensions [2nd attempt]. (Closed)
Patch Set: Fixing a silly mistake from the previous patchset - using absolute paths as needed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/BUILD.gn
diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
index dfeb244563af855ad00adf2b196e212db4c0fb0f..8d99b1387cbd218c25d8dcd0866ab8454498deea 100644
--- a/content/test/BUILD.gn
+++ b/content/test/BUILD.gn
@@ -723,6 +723,26 @@ test("content_browsertests") {
data = []
+ # Adding all //testing/buildbot/filters/*.content_browsertests.*filter files
+ # as a dependency.
+ #
+ # They might not be used on all platforms (e.g. there is no mac bot coverage
+ # for --site-per-process today), but for simplicity we just include all of
+ # them below (doing this should help avoid unpleasant surprises when a bot
+ # config is switched in testing/buildbot/chromium.fyi.json without
+ # corresponding dependency changes here).
alexmos 2016/11/03 01:12:14 nit: might be helpful to also add a reference to 6
Łukasz Anforowicz 2016/11/03 17:44:59 Done.
+ #
+ # To refresh, run the following command in bash:
+ # $ for i in $( \
+ # find testing/buildbot/filters -name '*.content_browsertests.*filter'); \
+ # do echo " \"//$i\","; done | sort
+ data += [
+ "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter",
+ "//testing/buildbot/filters/cast-linux.content_browsertests.filter",
alexmos 2016/11/03 01:12:14 I wonder how the Cast Linux bot manages to work, s
Łukasz Anforowicz 2016/11/03 17:45:47 Not sure :-( Adding slan@ and servolk@ and phajda
+ "//testing/buildbot/filters/isolate-extensions.content_browsertests.filter",
+ "//testing/buildbot/filters/site-per-process.content_browsertests.filter",
+ ]
+
data_deps = [
"//content/shell:pak",
"//third_party/mesa:osmesa",
@@ -761,7 +781,6 @@ test("content_browsertests") {
}
if (is_win || is_linux || is_android) {
- data += [ "//testing/buildbot/filters/site-per-process.content_browsertests.filter" ]
}
if (is_win) {
@@ -784,7 +803,6 @@ test("content_browsertests") {
if (is_linux) {
sources += [ "../zygote/zygote_browsertest.cc" ]
- data += [ "//testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter" ]
}
if (is_android) {
« no previous file with comments | « chrome/test/BUILD.gn ('k') | testing/buildbot/chromium.fyi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698