Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 246933007: Make <iframe> containing SVG behave as every other <iframe> (Closed)

Created:
6 years, 8 months ago by davve
Modified:
6 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, rwlbuis, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, ojan, Stephen Chennney, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make <iframe> containing SVG behave as every other <iframe> When an SVG is contained inside an <iframe>, its dimensions should not be part of size calculations of the <iframe>. Neither should the SVG's own width and height be ignored when sizing the <svg> inside the <iframe> The specification waters are murky here but this aligns Blink with Firefox and IE. BUG=308992, 364051 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172467

Patch Set 1 #

Patch Set 2 : Add NeedsRebaseline to test for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-iframe/svg-in-iframe.html View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderPart.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderPart.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderReplaced.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
davve
Something you think we should do, Philip? Aligning with the other feels right here, but ...
6 years, 8 months ago (2014-04-23 15:18:12 UTC) #1
pdr.
On 2014/04/23 15:18:12, David Vest wrote: > Something you think we should do, Philip? > ...
6 years, 8 months ago (2014-04-23 16:54:37 UTC) #2
davve
On 2014/04/23 16:54:37, pdr wrote: > On 2014/04/23 15:18:12, David Vest wrote: > > Something ...
6 years, 8 months ago (2014-04-24 07:12:57 UTC) #3
davve
The CQ bit was checked by davve@opera.com
6 years, 8 months ago (2014-04-24 07:22:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/246933007/20001
6 years, 8 months ago (2014-04-24 07:23:23 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 08:28:23 UTC) #6
Message was sent while issue was closed.
Change committed as 172467

Powered by Google App Engine
This is Rietveld 408576698