Issue 246933003: SPDY: Fix flaky padding edge case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246933003: SPDY: Fix flaky padding edge case. (Closed)

Created:
6 years, 8 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SPDY: Fix flaky padding edge case. The root cause of the flakiness is: during the processing of data frame, the visitor should be informed if the FIN flag is set and there is no more data in this frame. One corner case that has not been covered is when remaining_data_length_ = remaining_padding_payload_length_ = 0, which does happen when the data payload is empty (e.g., GET request) and the padding len is exactly 1. This lands server change 64513441 by raullenchai. BUG=345769

Patch Set 1 #

Patch Set 2 : Rebase only. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -14 lines)			Patch
M	net/spdy/spdy_framer.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1	4 chunks	+28 lines, -14 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages