Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3647)

Unified Diff: base/task_scheduler/post_task.h

Issue 2469323002: Document TaskRunners/TaskTraits/FROM_HERE as implicitly included from post_task.h (Closed)
Patch Set: Keep header ordering, add comment after Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/post_task.h
diff --git a/base/task_scheduler/post_task.h b/base/task_scheduler/post_task.h
index 70aebd51c402ac15ee132d75fc8d886d2dfe1f49..711693710f9597ff45e025d95521952e5c14cc48 100644
--- a/base/task_scheduler/post_task.h
+++ b/base/task_scheduler/post_task.h
@@ -14,6 +14,10 @@
#include "base/task_runner.h"
#include "base/task_scheduler/task_traits.h"
+// To avoid redundant includes: users may omit including the following headers
+// if they are using their provided data types solely in direct interactions
+// with this API: location.h, task_traits.h, and *task_runner.h.
robliao 2016/11/02 20:13:55 Is the asterisk in task_runner.h intentional?
gab 2016/11/02 20:25:21 Yes, it applies to all 3 TaskRunner headers.
danakj 2016/11/02 22:58:01 I think this comment is overprescribing things, ju
+
namespace base {
// This is the preferred interface to post tasks to the TaskScheduler.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698