chrome/test/data/push_messaging/service_worker.js - Issue 2469293002: Handle push resubscribes with no sender info (avoids DCHECK)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/push_messaging/service_worker.js

Issue 2469293002: Handle push resubscribes with no sender info (avoids DCHECK) (Closed)

Patch Set: call it fixed_sender_id when it is (hopefully) fixed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/push_messaging/service_worker.js

diff --git a/chrome/test/data/push_messaging/service_worker.js b/chrome/test/data/push_messaging/service_worker.js

index 0e134855652b0d9035a39de5fed5584612bddb8b..d59a933652977e5efae00e489ea54f71238aa1f4 100644

--- a/chrome/test/data/push_messaging/service_worker.js

+++ b/chrome/test/data/push_messaging/service_worker.js

@@ -51,6 +51,9 @@ self.addEventListener('message', function handler (event) {

};

if (event.data.command == 'workerSubscribe') {

pushSubscriptionOptions.applicationServerKey = kApplicationServerKey.buffer;

+ } else if (event.data.command == 'workerSubscribeWithNumericKey') {

+ pushSubscriptionOptions.applicationServerKey =

+ new TextEncoder().encode('1234567890');

} else if (event.data.command == 'workerSubscribeNoKey') {

// Nothing to set up

} else {