Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: chrome/test/data/push_messaging/service_worker.js

Issue 2469293002: Handle push resubscribes with no sender info (avoids DCHECK) (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/push_messaging/service_worker.js
diff --git a/chrome/test/data/push_messaging/service_worker.js b/chrome/test/data/push_messaging/service_worker.js
index 0e134855652b0d9035a39de5fed5584612bddb8b..d8c34929fcd9b5e7dbb4cd0f51fe9bce3c2cdf17 100644
--- a/chrome/test/data/push_messaging/service_worker.js
+++ b/chrome/test/data/push_messaging/service_worker.js
@@ -51,6 +51,9 @@ self.addEventListener('message', function handler (event) {
};
if (event.data.command == 'workerSubscribe') {
pushSubscriptionOptions.applicationServerKey = kApplicationServerKey.buffer;
+ } else if (event.data.command == 'workerSubscribePushWithNumber') {
harkness 2016/11/02 18:48:12 nit NumericKey?
awdf 2016/11/03 14:10:11 Oops, this actually isn't called, (since it's one
awdf 2016/11/07 16:54:30 Reinstated. Discussing with John we figured it's n
+ pushSubscriptionOptions.applicationServerKey =
+ new TextEncoder().encode('1234567890');
} else if (event.data.command == 'workerSubscribeNoKey') {
// Nothing to set up
} else {

Powered by Google App Engine
This is Rietveld 408576698