chrome/test/data/push_messaging/test_no_manifest.html - Issue 2469293002: Handle push resubscribes with no sender info (avoids DCHECK)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/push_messaging/test_no_manifest.html

Issue 2469293002: Handle push resubscribes with no sender info (avoids DCHECK) (Closed)

Patch Set: call it fixed_sender_id when it is (hopefully) fixed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Push API Test</title>	4 <title>Push API Test</title>

5 <link rel="manifest" href="manifest.json">

6 <script src="../result_queue.js"></script>	5 <script src="../result_queue.js"></script>

7 <script src="push_constants.js"></script>	6 <script src="push_constants.js"></script>

8 <script src="push_test.js"></script>	7 <script src="push_test.js"></script>

9 </head>	8 </head>

10 <body>	9 <body>

11 <h1>Push API Test</h1>	10 <h1>Push API Test</h1>

12 </body>	11 </body>

13 </html>	12 </html>

OLD	NEW