Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2469283002: [Interpreter] Remove skips from mjsunit tests which now pass. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove skips from mjsunit tests which now pass. BUG=v8:4680 Committed: https://crrev.com/0fbf7243c658b7af8adefe5112dd947598a40fab Cr-Commit-Position: refs/heads/master@{#40706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M test/mjsunit/mjsunit.status View 5 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rmcilroy
Michael, these tests now seem fine on the try bots. I added all the bots ...
4 years, 1 month ago (2016-11-02 14:00:43 UTC) #6
Michael Achenbach
LGTM. There might be a few whose configuration simply doesn't exist on trybots. We also ...
4 years, 1 month ago (2016-11-02 14:04:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469283002/1
4 years, 1 month ago (2016-11-02 14:44:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 14:46:30 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fbf7243c658b7af8adefe5112dd947598a40fab
Cr-Commit-Position: refs/heads/master@{#40706}

Powered by Google App Engine
This is Rietveld 408576698