[stubs] Add a utility class to generate code to access builtin arguments

[stubs] Add a utility class to generate code to access builtin arguments

With an instance of CodeStubArguments, builtin stub generators can generate code
that accesses the receiver passed to the builtin, as well as access and iterate
over the variable number of arguments that are passed in.

Committed: https://crrev.com/2445a502dd97d1779d91db70f81018fc41968d43
Cr-Commit-Position: refs/heads/master@{#40726}

[danno, 2016-11-03 06:40:12]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 06:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 06:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 06:43:51]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15550)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[danno, 2016-11-03 06:55:39]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 06:55:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-11-03 06:56:41]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org, ishell@chromium.org

[danno, 2016-11-03 06:56:42]

PTAL

[commit-bot: I haz the power, 2016-11-03 07:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 07:19:56]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-11-03 11:52:20]

lgtm once the comments are addressed

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:8768: (StandardFrameConstants::kFixedSlotCountFromFp
- 1) * kPointerSize);
I think you meant kFixedSlotCountAboveFp here.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:8786:
assembler_->IntPtrSubFoldConstants(assembler_->IntPtrConstant(0), index);
IntPtrOrSmiConstant(0, mode) to be consistent.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:8804: first = assembler_->IntPtrConstant(0);
IntPtrOrSmiConstant(0, mode) to be consistent

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1215: CodeStubArguments(CodeStubAssembler* assembler,
compiler::Node* argc,
Please add a comment that argc does not include receiver.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1221: compiler::Node* AtIndex(compiler::Node* index,
index is zero-based, not including receiver.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1230: void ForEach(ForEachBodyFunction body,
compiler::Node* first = nullptr,
Please mention that this iteration does not include receiver.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1238: void ForEach(const
CodeStubAssembler::VariableList& vars,
Same here.

[danno, 2016-11-03 12:05:47]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 12:05:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 12:31:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 12:31:47]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-11-03 12:48:41]

LGTM on compiler.

[danno, 2016-11-03 12:50:28]

The CQ bit was checked by danno@chromium.org

[danno, 2016-11-03 12:50:28]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2469273003/#ps80001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-11-03 12:50:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 12:53:28]

Committed patchset #5 (id:80001)

[danno, 2016-11-03 15:01:48]

Feedback addressed, landed

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:8768: (StandardFrameConstants::kFixedSlotCountFromFp
- 1) * kPointerSize);
On 2016/11/03 11:52:20, Igor Sheludko wrote:
> I think you meant kFixedSlotCountAboveFp here.

Done.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:8786:
assembler_->IntPtrSubFoldConstants(assembler_->IntPtrConstant(0), index);
On 2016/11/03 11:52:20, Igor Sheludko wrote:
> IntPtrOrSmiConstant(0, mode) to be consistent.

Done.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.cc:8804: first = assembler_->IntPtrConstant(0);
On 2016/11/03 11:52:20, Igor Sheludko wrote:
> IntPtrOrSmiConstant(0, mode) to be consistent

Done.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler.h
File src/code-stub-assembler.h (right):

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1215: CodeStubArguments(CodeStubAssembler* assembler,
compiler::Node* argc,
On 2016/11/03 11:52:20, Igor Sheludko wrote:
> Please add a comment that argc does not include receiver.

Done.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1221: compiler::Node* AtIndex(compiler::Node* index,
On 2016/11/03 11:52:20, Igor Sheludko wrote:
> index is zero-based, not including receiver.

Done.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1230: void ForEach(ForEachBodyFunction body,
compiler::Node* first = nullptr,
On 2016/11/03 11:52:20, Igor Sheludko wrote:
> Please mention that this iteration does not include receiver.

Done.

https://codereview.chromium.org/2469273003/diff/60001/src/code-stub-assembler...
src/code-stub-assembler.h:1238: void ForEach(const
CodeStubAssembler::VariableList& vars,
On 2016/11/03 11:52:20, Igor Sheludko wrote:
> Same here.

Done.

[commit-bot: I haz the power, 2016-11-17 22:20:40]

Description was changed from

==========
[stubs] Add a utility class to generate code to access builtin arguments

With an instance of CodeStubArguments, builtin stub generators can generate code
that accesses the receiver passed to the builtin, as well as access and iterate
over the variable number of arguments that are passed in.
==========

to

==========
[stubs] Add a utility class to generate code to access builtin arguments

With an instance of CodeStubArguments, builtin stub generators can generate code
that accesses the receiver passed to the builtin, as well as access and iterate
over the variable number of arguments that are passed in.

Committed: https://crrev.com/2445a502dd97d1779d91db70f81018fc41968d43
Cr-Commit-Position: refs/heads/master@{#40726}
==========

[commit-bot: I haz the power, 2016-11-17 22:20:41]

Patchset 5 (id:??) landed as
https://crrev.com/2445a502dd97d1779d91db70f81018fc41968d43
Cr-Commit-Position: refs/heads/master@{#40726}