Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2469273002: [heap] Exclude the owner of the linear allocation area from evacuation. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Exclude the owner of the linear allocation area from evacuation. This ensures that incremental marking step does not change the top and limit pointers of the old space, which is needed for allocation folding. For more info see: https://bugs.chromium.org/p/chromium/issues/detail?id=659165#c13 BUG=chromium:659165 Committed: https://crrev.com/e7aa6f91b3411f47a429e22b2e20635426ad3836 Cr-Commit-Position: refs/heads/master@{#40720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M src/heap/mark-compact.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
PTAL. Sadly no regression test because it depends on timing of end of sweeping, start ...
4 years, 1 month ago (2016-11-02 10:38:30 UTC) #2
Michael Lippautz
lgtm +1 on this solution
4 years, 1 month ago (2016-11-02 12:37:53 UTC) #3
Hannes Payer (out of office)
LGTM With that CL, we are not selecting the currently used page for bump pointer ...
4 years, 1 month ago (2016-11-03 10:58:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469273002/1
4 years, 1 month ago (2016-11-03 11:47:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 12:12:47 UTC) #9
ulan
On 2016/11/03 10:58:47, Hannes Payer wrote: > LGTM > > With that CL, we are ...
4 years, 1 month ago (2016-11-03 13:38:11 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7aa6f91b3411f47a429e22b2e20635426ad3836
Cr-Commit-Position: refs/heads/master@{#40720}

Powered by Google App Engine
This is Rietveld 408576698