Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2469233002: [DONT COMMIT] DevTools: Make WorkerThreadDebugger available for Worklets [1] (Closed)

Created:
4 years, 1 month ago by nhiroki
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make WorkerThreadDebugger available for Worklets [1] This is a preparation to change an interface of ThreadDebugger. See [2] for details. [1] Chromium: THIS PATCH [2] V8: https://codereview.chromium.org/2451893005/ [3] Chromium: https://codereview.chromium.org/2456733002/ BUG=646559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (6 generated)
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 07:36:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469233002/1
4 years, 1 month ago (2016-11-02 07:37:09 UTC) #2
nhiroki
Description was changed from ========== DevTools: Make WorkerThreadDebugger available for Worklets [1] [1] Chromium: THIS ...
4 years, 1 month ago (2016-11-02 08:02:40 UTC) #3
nhiroki
Description was changed from ========== DevTools: Make WorkerThreadDebugger available for Worklets [1] This is a ...
4 years, 1 month ago (2016-11-02 08:19:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 09:06:40 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 09:06:40 UTC) #6
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698