Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 246923004: Try to fix ProfileBrowserTest, again. (Closed)

Created:
6 years, 8 months ago by Marc Treib
Modified:
6 years, 7 months ago
Reviewers:
rpetterson
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Try to fix ProfileBrowserTest, again. Previous CL (which caused memleaks): https://codereview.chromium.org/225693005 BUG=165760, 140882, 141141, 141517, 142787 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -90 lines) Patch
M chrome/browser/profiles/profile_browsertest.cc View 10 chunks +135 lines, -90 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Marc Treib
Let's try this again... It turns out that StartupTaskRunnerService::StartDeferredTaskRunners is required after all, to prevent ...
6 years, 8 months ago (2014-04-22 17:22:33 UTC) #1
Marc Treib
6 years, 8 months ago (2014-04-22 17:24:21 UTC) #2
rpetterson
Thanks for your perseverance in cleaning these tests up! LGTM
6 years, 8 months ago (2014-04-24 20:36:01 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-28 07:25:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/246923004/1
6 years, 7 months ago (2014-04-28 07:26:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 08:16:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 08:16:38 UTC) #7
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-28 08:21:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/246923004/1
6 years, 7 months ago (2014-04-28 08:21:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 08:35:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 08:35:55 UTC) #11
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-29 07:27:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/246923004/1
6 years, 7 months ago (2014-04-29 07:28:08 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 08:37:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 08:37:25 UTC) #15
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-29 08:45:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/246923004/1
6 years, 7 months ago (2014-04-29 08:47:45 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 09:41:23 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 09:41:24 UTC) #19
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-29 10:46:46 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/246923004/1
6 years, 7 months ago (2014-04-29 10:47:04 UTC) #21
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 11:30:44 UTC) #22
Message was sent while issue was closed. 
Change committed as 266850

Powered by Google App Engine
This is Rietveld 408576698