Fix enum in UMA Extensions.OffStoreInstallDecisionHard

Fix enum in UMA Extensions.OffStoreInstallDecisionHard

OffStoreInstallDisallowed should be
OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2.
However, it is resolved to be
OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0.
This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441
Committed: https://crrev.com/f902f2c3194edaffd899ca7a5a9689d2b71568da
Cr-Commit-Position: refs/heads/master@{#429424}

[wychen, 2016-11-02 04:19:35]

wychen@chromium.org changed reviewers:
+ asargent@chromium.org

[wychen, 2016-11-02 04:19:36]

PTAL

[wychen, 2016-11-02 04:28:27]

Description was changed from

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

BUG=661441
==========

to

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441
==========

[asargent_no_longer_on_chrome, 2016-11-02 19:31:03]

Can you explain "This caused wrong bucket assignment" a little bit more? It's
not obvious to me from looking at https://codereview.chromium.org/2469993002/
why this is the case.

[wychen, 2016-11-02 20:12:13]

Description was changed from

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441
==========

to

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

OffStoreInstallDisallowed should be
OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2.
However, it is resolved to be
OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0. 
This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441
==========

[wychen, 2016-11-02 20:13:17]

On 2016/11/02 19:31:03, Antony Sargent wrote:
> Can you explain "This caused wrong bucket assignment" a little bit more? It's
> not obvious to me from looking at https://codereview.chromium.org/2469993002/
> why this is the case.

Ah. I explained it in the bug, but the description was too vague.
I've updated the CL description.

[asargent_no_longer_on_chrome, 2016-11-02 20:38:28]

Ah, thanks for the additional explanation. 

lgtm

[wychen, 2016-11-02 21:09:25]

Thanks for your prompt review.

BTW, "Extensions.OffStoreInstallDecisionHard" is not defined in histograms.xml.
Does this mean nobody is looking at it now? If so, maybe we can clean up these
code.

[wychen, 2016-11-02 21:11:24]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2016-11-02 21:12:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:33:54]

Description was changed from

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

OffStoreInstallDisallowed should be
OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2.
However, it is resolved to be
OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0. 
This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441
==========

to

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

OffStoreInstallDisallowed should be
OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2.
However, it is resolved to be
OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0. 
This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441
==========

[commit-bot: I haz the power, 2016-11-02 22:33:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-02 22:36:57]

Description was changed from

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

OffStoreInstallDisallowed should be
OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2.
However, it is resolved to be
OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0. 
This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441
==========

to

==========
Fix enum in UMA Extensions.OffStoreInstallDecisionHard

OffStoreInstallDisallowed should be
OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2.
However, it is resolved to be
OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0.
This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG=661441

Committed: https://crrev.com/f902f2c3194edaffd899ca7a5a9689d2b71568da
Cr-Commit-Position: refs/heads/master@{#429424}
==========

[commit-bot: I haz the power, 2016-11-02 22:36:58]

Patchset 1 (id:??) landed as
https://crrev.com/f902f2c3194edaffd899ca7a5a9689d2b71568da
Cr-Commit-Position: refs/heads/master@{#429424}