Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 2469133003: Fix some UMA enum type mismatches (Closed)

Created:
4 years, 1 month ago by wychen
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some UMA enum type mismatches These only affects the number of buckets. The number of buckets were too large, so the bug didn't affect UMA analysis. This was discovered by the checks implemented in this CL: https://codereview.chromium.org/2469993002/ BUG=661401 Committed: https://crrev.com/a4484a668c810bc78360cfe4ea03b573dcdf4dc8 Cr-Commit-Position: refs/heads/master@{#429406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
wychen
PTAL
4 years, 1 month ago (2016-11-02 04:31:11 UTC) #3
gavinp
net/ lgtm
4 years, 1 month ago (2016-11-02 15:30:29 UTC) #4
Roger Tawa OOO till Jul 10th
inline_login_handler_impl.cc lgtm
4 years, 1 month ago (2016-11-02 17:42:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469133003/1
4 years, 1 month ago (2016-11-02 20:15:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 21:34:13 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 21:36:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4484a668c810bc78360cfe4ea03b573dcdf4dc8
Cr-Commit-Position: refs/heads/master@{#429406}

Powered by Google App Engine
This is Rietveld 408576698