Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: url/url_canon_icu_unittest.cc

Issue 2469133002: Clean up URL test string conversions. (Closed)
Patch Set: More Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « url/gurl_unittest.cc ('k') | url/url_canon_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/url_canon_icu_unittest.cc
diff --git a/url/url_canon_icu_unittest.cc b/url/url_canon_icu_unittest.cc
index 13601f028c5f1078717450f62e57bab8760e6527..af320f9bf9368cb5e4450b3d967695df63a8f765 100644
--- a/url/url_canon_icu_unittest.cc
+++ b/url/url_canon_icu_unittest.cc
@@ -14,8 +14,6 @@
namespace url {
-using test_utils::WStringToUTF16;
-
namespace {
// Wrapper around a UConverter object that managers creation and destruction.
@@ -64,7 +62,8 @@ TEST(URLCanonIcuTest, ICUCharsetConverter) {
std::string str;
StdStringCanonOutput output(&str);
- base::string16 input_str(WStringToUTF16(icu_cases[i].input));
+ base::string16 input_str(
+ test_utils::TruncateWStringToUTF16(icu_cases[i].input));
int input_len = static_cast<int>(input_str.length());
converter.ConvertFromUTF16(input_str.c_str(), input_len, &output);
output.Complete();
@@ -134,7 +133,8 @@ TEST(URLCanonIcuTest, QueryWithConverter) {
}
if (query_cases[i].input16) {
- base::string16 input16(WStringToUTF16(query_cases[i].input16));
+ base::string16 input16(
+ test_utils::TruncateWStringToUTF16(query_cases[i].input16));
int len = static_cast<int>(input16.length());
Component in_comp(0, len);
std::string out_str;
« no previous file with comments | « url/gurl_unittest.cc ('k') | url/url_canon_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698