Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2469133002: Clean up URL test string conversions. (Closed)

Created:
4 years, 1 month ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
Mike West
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up URL test string conversions. Originally the url test utils had UTF string conversion functions because we didn't want the library to depend on STL (for embedders). We've not had this limitation for a long time so the UTF16 <--> UTF8 conversion functions can be deleted in favor of the ones in base. The one remaining function which generates possibly-invalid UTF16 (by design) is renamed and clarified for this purpose. Committed: https://crrev.com/1b8582fe4716a6761c6abe606ca0e8a987e3435c Cr-Commit-Position: refs/heads/master@{#429688}

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : More #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -64 lines) Patch
M url/gurl_unittest.cc View 1 2 7 chunks +11 lines, -10 lines 0 comments Download
M url/url_canon_icu_unittest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M url/url_canon_unittest.cc View 1 18 chunks +32 lines, -24 lines 0 comments Download
M url/url_test_utils.h View 3 chunks +7 lines, -23 lines 0 comments Download
M url/url_util_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
brettw
More
4 years, 1 month ago (2016-11-01 23:05:37 UTC) #1
brettw
More
4 years, 1 month ago (2016-11-01 23:09:01 UTC) #2
brettw
4 years, 1 month ago (2016-11-01 23:09:42 UTC) #4
Mike West
LGTM. :)
4 years, 1 month ago (2016-11-03 12:22:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469133002/40001
4 years, 1 month ago (2016-11-03 19:45:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-03 20:37:42 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 20:40:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b8582fe4716a6761c6abe606ca0e8a987e3435c
Cr-Commit-Position: refs/heads/master@{#429688}

Powered by Google App Engine
This is Rietveld 408576698