Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 246913003: [fsp] Add support for reading directories. (Closed)

Created:
6 years, 8 months ago by mtomasz
Modified:
6 years, 7 months ago
Reviewers:
benwells, hirono, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] Add support for reading directories. This patch adds support to list contents of directories. TBR=isherman@chromium.org TEST=unit_tests, browser_test: *FileSystemProvider*ReadDirectory BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269201

Patch Set 1 #

Patch Set 2 : Tiny cleanup. #

Patch Set 3 : Fixed. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased + added more tests. #

Patch Set 6 : New version. #

Total comments: 10

Patch Set 7 : Addressed comments + rebased. #

Total comments: 8

Patch Set 8 : Fixed. #

Patch Set 9 : Addressed comments. #

Patch Set 10 : Rebased. #

Patch Set 11 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+674 lines, -88 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 2 3 4 5 6 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/provider_function.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 2 3 4 5 2 chunks +68 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 1 2 3 4 5 2 chunks +33 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/read_directory.h View 1 2 3 4 5 3 chunks +11 lines, -11 lines 0 comments Download
A chrome/browser/chromeos/file_system_provider/operations/read_directory.cc View 1 2 3 4 5 1 chunk +94 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc View 1 2 3 4 5 8 chunks +75 lines, -62 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 1 2 3 4 5 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_value.h View 1 2 3 4 5 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_value.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 2 3 4 5 6 4 chunks +21 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_internal.idl View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js View 1 2 3 4 5 6 7 8 3 chunks +48 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/file_system_provider/read_directory/manifest.json View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/file_system_provider/read_directory/test.js View 1 2 3 4 5 6 7 1 chunk +201 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (0 generated)
mtomasz
This patch is mostly a copy paste of the getMetadata operation (https://codereview.chromium.org/258783006/). @hashimoto: PTAL at ...
6 years, 7 months ago (2014-05-02 08:22:21 UTC) #1
benwells
lgtm https://codereview.chromium.org/246913003/diff/100001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/246913003/diff/100001/chrome/common/extensions/api/file_system_provider.idl#newcode121 chrome/common/extensions/api/file_system_provider.idl:121: // Raised when contents of a directory at ...
6 years, 7 months ago (2014-05-05 01:07:24 UTC) #2
mtomasz
On 2014/05/05 01:07:24, benwells wrote: > lgtm > > https://codereview.chromium.org/246913003/diff/100001/chrome/common/extensions/api/file_system_provider.idl > File chrome/common/extensions/api/file_system_provider.idl (right): > ...
6 years, 7 months ago (2014-05-06 12:09:43 UTC) #3
hirono
https://codereview.chromium.org/246913003/diff/100001/chrome/test/data/extensions/api_test/file_system_provider/read_directory/test.js File chrome/test/data/extensions/api_test/file_system_provider/read_directory/test.js (right): https://codereview.chromium.org/246913003/diff/100001/chrome/test/data/extensions/api_test/file_system_provider/read_directory/test.js#newcode58 chrome/test/data/extensions/api_test/file_system_provider/read_directory/test.js:58: * @param {string} entryPath Path of the directory. directoryPath? ...
6 years, 7 months ago (2014-05-07 04:12:23 UTC) #4
mtomasz
https://codereview.chromium.org/246913003/diff/100001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/246913003/diff/100001/chrome/common/extensions/api/file_system_provider.idl#newcode121 chrome/common/extensions/api/file_system_provider.idl:121: // Raised when contents of a directory at <code>directoryPath</code> ...
6 years, 7 months ago (2014-05-07 04:57:30 UTC) #5
hirono
https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js File chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js (right): https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js#newcode17 chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js:17: * @return {Date} Date with an extra <code>value</code> attribute ...
6 years, 7 months ago (2014-05-07 05:48:58 UTC) #6
kinaba
lgtm
6 years, 7 months ago (2014-05-07 06:44:29 UTC) #7
mtomasz
https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js File chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js (right): https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js#newcode17 chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js:17: * @return {Date} Date with an extra <code>value</code> attribute ...
6 years, 7 months ago (2014-05-07 06:57:09 UTC) #8
hirono
https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js File chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js (right): https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js#newcode153 chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js:153: entries.forEach(function(metadata) { On 2014/05/07 06:57:09, mtomasz wrote: > On ...
6 years, 7 months ago (2014-05-07 07:01:50 UTC) #9
mtomasz
https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js File chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js (right): https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js#newcode153 chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js:153: entries.forEach(function(metadata) { On 2014/05/07 07:01:51, hirono wrote: > On ...
6 years, 7 months ago (2014-05-07 07:24:32 UTC) #10
hirono
On 2014/05/07 07:24:32, mtomasz wrote: > https://codereview.chromium.org/246913003/diff/140001/chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js > File > chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js > (right): > > ...
6 years, 7 months ago (2014-05-07 07:25:16 UTC) #11
mtomasz
@isherman: TBR. PTAL at added histograms. Thanks.
6 years, 7 months ago (2014-05-07 07:27:02 UTC) #12
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 07:27:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/246913003/200001
6 years, 7 months ago (2014-05-07 07:28:46 UTC) #14
mtomasz
The CQ bit was unchecked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 12:11:00 UTC) #15
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 12:11:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/246913003/200001
6 years, 7 months ago (2014-05-07 12:14:14 UTC) #17
mtomasz
The CQ bit was unchecked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 13:39:28 UTC) #18
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 13:39:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/246913003/200001
6 years, 7 months ago (2014-05-07 13:43:56 UTC) #20
mtomasz
The CQ bit was unchecked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 13:49:43 UTC) #21
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 13:49:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/246913003/200001
6 years, 7 months ago (2014-05-07 13:55:41 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 18:07:01 UTC) #24
commit-bot: I haz the power
Failed to apply patch for extensions/browser/extension_function_histogram_value.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-07 18:07:02 UTC) #25
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-07 23:59:58 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/246913003/220001
6 years, 7 months ago (2014-05-08 00:03:49 UTC) #27
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 05:41:51 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 05:48:02 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium
6 years, 7 months ago (2014-05-08 05:48:02 UTC) #30
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-09 01:16:24 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/246913003/240001
6 years, 7 months ago (2014-05-09 01:25:26 UTC) #32
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 09:40:36 UTC) #33
Message was sent while issue was closed. 
Change committed as 269201

Powered by Google App Engine
This is Rietveld 408576698