Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2469043003: [debugger] fix blacklisted tests. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] fix blacklisted tests. BUG=v8:5581 R=jgruber@chromium.org Committed: https://crrev.com/acd0c3cf760c0ce40b4b2156400d1dd2f5736f82 Cr-Commit-Position: refs/heads/master@{#40793}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix 2318 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -110 lines) Patch
M test/mjsunit/es6/debug-step-into-constructor.js View 7 chunks +23 lines, -18 lines 0 comments Download
M test/mjsunit/es6/default-parameters-debug.js View 2 chunks +10 lines, -14 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +1 line, -11 lines 0 comments Download
M test/mjsunit/regress/regress-2296.js View 1 chunk +5 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-2318.js View 1 2 chunks +9 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-4703.js View 3 chunks +7 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-5071.js View 2 chunks +13 lines, -6 lines 0 comments Download
D test/mjsunit/regress/regress-998565.js View 1 chunk +0 lines, -51 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-107996.js View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
4 years, 1 month ago (2016-11-02 11:14:20 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2469043003/diff/1/test/mjsunit/regress/regress-2296.js File test/mjsunit/regress/regress-2296.js (right): https://codereview.chromium.org/2469043003/diff/1/test/mjsunit/regress/regress-2296.js#newcode36 test/mjsunit/regress/regress-2296.js:36: assertTrue(String(e).indexOf("Source is not a string") > 0); I ...
4 years, 1 month ago (2016-11-07 07:50:57 UTC) #2
Yang
https://codereview.chromium.org/2469043003/diff/1/test/mjsunit/regress/regress-2296.js File test/mjsunit/regress/regress-2296.js (right): https://codereview.chromium.org/2469043003/diff/1/test/mjsunit/regress/regress-2296.js#newcode36 test/mjsunit/regress/regress-2296.js:36: assertTrue(String(e).indexOf("Source is not a string") > 0); On 2016/11/07 ...
4 years, 1 month ago (2016-11-07 08:35:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469043003/1
4 years, 1 month ago (2016-11-07 08:35:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/7404) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-07 08:58:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469043003/20001
4 years, 1 month ago (2016-11-07 09:19:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 09:43:13 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:24:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acd0c3cf760c0ce40b4b2156400d1dd2f5736f82
Cr-Commit-Position: refs/heads/master@{#40793}

Powered by Google App Engine
This is Rietveld 408576698