Issue 246903005: gclient_scm: Assume URLs containing 'googlesource' are for Git repos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246903005: gclient_scm: Assume URLs containing 'googlesource' are for Git repos (Closed)

Created:
6 years, 8 months ago by borenet

Modified:
6 years, 8 months ago

Reviewers:
iannucci, ebeach

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

gclient_scm: Assume URLs containing 'googlesource' are for Git repos Fixes this flow, which currently assumes we're using an svn checkout: gclient config https://chromium.googlesource.com/chromium/blink gclient sync BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265369

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	gclient_scm.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

iannucci

yayhax lgtm "We'll never host anything besides git repos on googlesource" -- iannucci@ (famous last ...

6 years, 8 months ago (2014-04-22 21:24:06 UTC) #2

borenet

On 2014/04/22 21:24:06, iannucci wrote: > yayhax lgtm > > "We'll never host anything besides ...

6 years, 8 months ago (2014-04-22 21:32:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/246903005/1

6 years, 8 months ago (2014-04-22 21:33:04 UTC) #5

Message was sent while issue was closed.

Change committed as 265369