Keep the toolbar overflow menu the same when removing a component action

Keep the toolbar overflow menu the same when removing a component action

Currently, when you remove a component action from the toolbar while there are actions in the overflow menu, one of the actions gets popped out of the menu to fill the component action's position. This CL makes such actions stay in the overflow menu.

BUG=661301
Committed: https://crrev.com/8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f
Cr-Commit-Position: refs/heads/master@{#429645}

[takumif, 2016-11-02 00:08:17]

Description was changed from

==========
.

BUG=
==========

to

==========
Keep the toolbar overflow menu the same when removing a component action



BUG=661301
==========

[takumif, 2016-11-02 00:14:21]

Description was changed from

==========
Keep the toolbar overflow menu the same when removing a component action



BUG=661301
==========

to

==========
Keep the toolbar overflow menu the same when removing a component action

Currently, when you remove a component action from the toolbar while there are
actions in the overflow menu, one of the actions gets popped out of the menu to
fill the component action's position. This CL makes such actions stay in the
overflow menu.

BUG=661301
==========

[takumif, 2016-11-02 00:14:21]

takumif@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[takumif, 2016-11-02 00:18:36]

Please take a look, thanks!
This CL is unrelated to the crash caused by calling AddComponentAction() before
initialization.

[Devlin, 2016-11-02 23:33:32]

lgtm

[takumif, 2016-11-03 00:21:24]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:22:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:17:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[takumif, 2016-11-03 02:28:06]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 02:28:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:48:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 02:48:29]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-11-03 17:44:35]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 17:45:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 17:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 17:50:15]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-11-03 17:51:36]

On 2016/11/02 23:33:32, Devlin (slow) wrote:
> lgtm

Thanks!

[takumif, 2016-11-03 17:51:38]

On 2016/11/02 23:33:32, Devlin (slow) wrote:
> lgtm

Thanks!

[takumif, 2016-11-03 17:51:46]

The CQ bit was checked by takumif@chromium.org

[commit-bot: I haz the power, 2016-11-03 17:52:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 17:58:40]

Description was changed from

==========
Keep the toolbar overflow menu the same when removing a component action

Currently, when you remove a component action from the toolbar while there are
actions in the overflow menu, one of the actions gets popped out of the menu to
fill the component action's position. This CL makes such actions stay in the
overflow menu.

BUG=661301
==========

to

==========
Keep the toolbar overflow menu the same when removing a component action

Currently, when you remove a component action from the toolbar while there are
actions in the overflow menu, one of the actions gets popped out of the menu to
fill the component action's position. This CL makes such actions stay in the
overflow menu.

BUG=661301
==========

[commit-bot: I haz the power, 2016-11-03 17:58:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 18:14:31]

Description was changed from

==========
Keep the toolbar overflow menu the same when removing a component action

Currently, when you remove a component action from the toolbar while there are
actions in the overflow menu, one of the actions gets popped out of the menu to
fill the component action's position. This CL makes such actions stay in the
overflow menu.

BUG=661301
==========

to

==========
Keep the toolbar overflow menu the same when removing a component action

Currently, when you remove a component action from the toolbar while there are
actions in the overflow menu, one of the actions gets popped out of the menu to
fill the component action's position. This CL makes such actions stay in the
overflow menu.

BUG=661301

Committed: https://crrev.com/8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f
Cr-Commit-Position: refs/heads/master@{#429645}
==========

[commit-bot: I haz the power, 2016-11-03 18:14:31]

Patchset 1 (id:??) landed as
https://crrev.com/8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f
Cr-Commit-Position: refs/heads/master@{#429645}