Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2469002: - Add a pointer to Bootstrapper from Isolate.... (Closed)

Created:
10 years, 6 months ago by zarko
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

- Add a pointer to Bootstrapper from Isolate. - Remove AllStatic parent from Bootstrapper. - Add empty constructor to Boostrapper. - Mark Bootstrapper as forbidden to copy/assign. Committed: http://code.google.com/p/v8/source/detail?r=4771

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M src/bootstrapper.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/isolate.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zarko
10 years, 6 months ago (2010-06-01 13:55:20 UTC) #1
Vitaly Repeshko
10 years, 6 months ago (2010-06-01 14:53:45 UTC) #2
LGTM with issues addressed.

http://codereview.chromium.org/2469002/diff/1/3
File src/bootstrapper.h (right):

http://codereview.chromium.org/2469002/diff/1/3#newcode101
src/bootstrapper.h:101: DISALLOW_COPY_AND_ASSIGN(Bootstrapper);
DISALLOW_IMPLICIT_CONSTRUCTORS also disables the default constructor.

http://codereview.chromium.org/2469002/diff/1/4
File src/isolate.cc (right):

http://codereview.chromium.org/2469002/diff/1/4#newcode85
src/isolate.cc:85: bootstrapper_ = new Bootstrapper();
This should be below DisallowAllocationFailure.

Powered by Google App Engine
This is Rietveld 408576698