Issue 2469001: - Begin removing [static] qualifier from methods in StubCache....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2469001: - Begin removing [static] qualifier from methods in StubCache.... (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

- Begin removing [static] qualifier from methods in StubCache. - Move construction of StubCache to top of Isolate::Init. - Mark StubCache as forbidden to copy/assign. Committed: http://code.google.com/p/v8/source/detail?r=4772

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -138 lines)			Patch
M	src/ic.cc	View	1	16 chunks	+114 lines, -52 lines	0 comments	Download
M	src/isolate.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/stub-cache.h	View	1	3 chunks	+86 lines, -84 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 6 months ago (2010-06-01 15:35:44 UTC) #2

LGTM.

http://codereview.chromium.org/2469001/diff/1/2
File src/ic.cc (right):

http://codereview.chromium.org/2469001/diff/1/2#newcode845
src/ic.cc:845: code
=Isolate::Current()->stub_cache()->ComputeKeyedLoadStringLength(
nit: Missing space after '='.

http://codereview.chromium.org/2469001/diff/1/3
File src/isolate.cc (right):

http://codereview.chromium.org/2469001/diff/1/3#newcode82
src/isolate.cc:82: stub_cache_ = new StubCache();
Should be below DisallowAllocationFailure.

Expand Messages | Collapse Messages