Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2468993002: Delete builtins that became unused after source loading was refactored. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete builtins that became unused after source loading was refactored. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/206daf356ee65a27bb1d9b85b3e0fb7e75372105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -119 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +0 lines, -116 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Vyacheslav Egorov (Google)
Please take a look, John.
4 years, 1 month ago (2016-11-01 17:50:47 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-11-01 19:09:24 UTC) #3
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-02 14:02:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
206daf356ee65a27bb1d9b85b3e0fb7e75372105 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698