Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872
Committed: https://crrev.com/cd8d931dc59e273273701feae744adff8714c27f
Cr-Commit-Position: refs/heads/master@{#429147}

[Łukasz Anforowicz, 2016-11-01 16:39:20]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 16:39:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-11-01 17:28:32]

Description was changed from

==========
Call updateLayout...RunPostLayoutTasks on local document.

This CL moves the call to
internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
from the parent frame into the child frame.  This ensures that this
method works on a local document (the method doesn't support OOPIFs).

BUG=660872
==========

to

==========
Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872
==========

[Łukasz Anforowicz, 2016-11-01 17:28:37]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 17:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-11-01 17:30:02]

Description was changed from

==========
Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872
==========

to

==========
Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872
==========

[commit-bot: I haz the power, 2016-11-01 18:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:19:49]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-11-01 18:28:11]

lukasza@chromium.org changed reviewers:
+ tkent@chromium.org

[Łukasz Anforowicz, 2016-11-01 18:28:12]

tkent@, could you please take a look?

https://codereview.chromium.org/2468953002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt
(right):

https://codereview.chromium.org/2468953002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:1:
CONSOLE WARNING: Mixed Content: The page at
'https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-plugin.html'
was loaded over HTTPS, but requested an insecure plugin resource
'http://example.test:8000/security/mixedContent/resources/dummy.swf'. This
content should also be served over HTTPS.
It is okay to remove "line 10: " from test output, because "line 10" only
reports which line called
updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks.  This information
just leaks test implementation details and is not essential for test
verification (i.e. no real webpage would call
window.internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks).

"line 10: " is removed by postponing the call to
updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks via setTimeout
function (called in resources/frame-with-insecure-plugin.html) - this way when
the call happens the line number information is no longer present.

https://codereview.chromium.org/2468953002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe.html
(left):

https://codereview.chromium.org/2468953002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe.html:10:
internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks(document.querySelector('iframe'));
Moved to resources/frame-with-insecure-plugin.html

https://codereview.chromium.org/2468953002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe.html
(right):

https://codereview.chromium.org/2468953002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe.html:7:
testRunner.waitUntilDone();
waitUntilDone is needed to account for the delay introduced by the new
setTimeout call in resources/frame-with-insecure-plugin.html.

[tkent, 2016-11-01 23:03:57]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-11-01 23:03:57]

lgtm

[commit-bot: I haz the power, 2016-11-01 23:04:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 23:15:48]

Description was changed from

==========
Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872
==========

to

==========
Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872
==========

[commit-bot: I haz the power, 2016-11-01 23:15:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 23:19:27]

Description was changed from

==========
Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872
==========

to

==========
Make mixedContent/insecure-plugin-in-iframe.html test OOPIF-compatible.

The CL makes the following changes:

- Moves the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  from the parent frame into the child frame.  This ensures that this
  method works on a local document - this is important because the
  method doesn't support OOPIFs.

- Delays the call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  via window.setTimeout.  This ensures that the mixed content message
  does not include the line number of the call (and so appears the same
  with an without OOPIFs).  The line number used to indicate which line
  called internals.updateLayoutIgnore...heetsAndRunPostLayoutTasks and
  this piece of information is artificial (and not essential to test
  for) - no real page will call this test-only window.internals method.

- To make sure the test finishes *after* the delayed call to
  internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks
  a pair of testRunner.waitUntilDone / testRunner.notifyDone calls
  has been added.  Note that the subframe used to post a "done"
  message back to the opener, but this message was never listened to
  (and so the postMessage call can be deleted).

BUG=660872

Committed: https://crrev.com/cd8d931dc59e273273701feae744adff8714c27f
Cr-Commit-Position: refs/heads/master@{#429147}
==========

[commit-bot: I haz the power, 2016-11-01 23:19:28]

Patchset 2 (id:??) landed as
https://crrev.com/cd8d931dc59e273273701feae744adff8714c27f
Cr-Commit-Position: refs/heads/master@{#429147}