Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2468913002: Add CSSTiming to collect aggregate PLT-level stats about CSS. (Closed)
Patch Set: fix browser test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index e1d4d0851db841d51c57f99f5d644e24ff8a7f06..796017b1ecfedf132ec1ebbf2b0d057a5d548d62 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -536,3 +536,20 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
prerender::ORIGIN_NONE, false, false, base::TimeDelta()),
0);
}
+
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, CSSTiming) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ // Careful: Blink code clamps timestamps to 5us, so any CSS parsing we do here
+ // must take >> 5us, otherwise we'll log 0 for the value and it will remain
+ // unset here.
+ ui_test_utils::NavigateToURL(
+ browser(),
+ embedded_test_server()->GetURL("/page_load_metrics/page_with_css.html"));
+ NavigateToUntrackedUrl();
+
+ histogram_tester_.ExpectTotalCount(internal::kHistogramFirstContentfulPaint,
+ 1);
+ histogram_tester_.ExpectTotalCount(
+ "PageLoad.CSSTiming.Parse.BeforeFirstContentfulPaint", 1);
+}

Powered by Google App Engine
This is Rietveld 408576698