chrome/test/data/page_load_metrics/page_with_css.html - Issue 2468913002: Add CSSTiming to collect aggregate PLT-level stats about CSS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/page_load_metrics/page_with_css.html

Issue 2468913002: Add CSSTiming to collect aggregate PLT-level stats about CSS. (Closed)

Patch Set: add html comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Page with some CSS</title>

	3 <!--

	4 Load a bunch of stylesheets to ensure that we spent more than 5us of time

	5 parsing. Timestamps are clamped to 5us in the renderer to avoid timing

	6 attacks.

	7 -->

	8 <link rel="stylesheet" href="/dromaeo/application.css">
	Timothy Loh 2016/11/11 04:19:22 I'd expect that we only parse it once though... I'd expect that we only parse it once though... Charlie Harrison 2016/11/11 16:27:10 It is odd. The reason is that application.css is u Show quoted text On 2016/11/11 04:19:22, Timothy Loh wrote: > I'd expect that we only parse it once though... It is odd. The reason is that application.css is uncacheable (in parsed form) because it has a syntactically invalid first rule. This is fragile so I'll change the URL here. I'm not quite sure why the first rule is deemed invalid, even when I change it to @charset "utf-8", so I'm investigating that separately.
	9 <link rel="stylesheet" href="/dromaeo/application.css">

	10 <link rel="stylesheet" href="/dromaeo/application.css">

	11 <link rel="stylesheet" href="/dromaeo/application.css">

	12 <link rel="stylesheet" href="/dromaeo/application.css">

	13 <link rel="stylesheet" href="/dromaeo/application.css">

	14 <link rel="stylesheet" href="/dromaeo/application.css">

	15 <link rel="stylesheet" href="/dromaeo/application.css">

	16 <link rel="stylesheet" href="/dromaeo/application.css">

	17 <link rel="stylesheet" href="/dromaeo/application.css">

	18 <p>Mark me up!</p>

OLD	NEW