Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceObserver.h

Issue 2468883003: [ImageResource 0b] Decouple ImageResourceObserver::imageNotifyFinished() from notifyFinished() (Closed)
Patch Set: comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResourceObserver.h
diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h b/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h
index d46fe1cfa0a13941fc1e753c4f80525de2c0ad60..b1f5da8ede5cd434f9605d313c5444ec8011b99d 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h
+++ b/third_party/WebKit/Source/core/fetch/ImageResourceObserver.h
@@ -42,9 +42,8 @@ class CORE_EXPORT ImageResourceObserver {
// is the changed rect of the image.
virtual void imageChanged(ImageResource*, const IntRect* = 0) {}
- // Called just before ResourceClient::notifyFinished() would be called. This
- // is to avoid an ImageResourceObserver from being also a ResourceClient just
- // to be notified for load finish.
+ // Called just after imageChanged() if all image data is received or errored.
+ // TODO(hiroshige): Merge imageNotifyFinished() into imageChanged().
virtual void imageNotifyFinished(ImageResource*) {}
// Called to find out if this client wants to actually display the image. Used
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698