third_party/WebKit/Source/core/fetch/ImageResource.h - Issue 2468883003: [ImageResource 0b] Decouple ImageResourceObserver::imageNotifyFinished() from notifyFinished()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.h

Issue 2468883003: [ImageResource 0b] Decouple ImageResourceObserver::imageNotifyFinished() from notifyFinished() (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResource.h

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.h b/third_party/WebKit/Source/core/fetch/ImageResource.h

index e8780284d5540b2a92f03df906d8bda71e5222ba..6ce40f0e620f12d4cf8bba187a8ed10be43cc780 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.h

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.h

@@ -191,7 +191,8 @@ class CORE_EXPORT ImageResource final

void updateImageAndClearBuffer();

void clearImage();

// If not null, changeRect is the changed part of the image.

- void notifyObservers(const IntRect* changeRect = nullptr);

+ void notifyObservers(bool isNotifyingFinish,

kouhei (in TOK) 2016/11/30 03:48:22 Please change bool -> enum

hiroshige 2016/11/30 05:21:39 Done.

+ const IntRect* changeRect = nullptr);

void ensureImage();

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/ImageResource.cpp » ('j') | no next file with comments »