Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ImageResource.h

Issue 2468883003: [ImageResource 0b] Decouple ImageResourceObserver::imageNotifyFinished() from notifyFinished() (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 bool hasClientsOrObservers() const override { 183 bool hasClientsOrObservers() const override {
184 return Resource::hasClientsOrObservers() || !m_observers.isEmpty() || 184 return Resource::hasClientsOrObservers() || !m_observers.isEmpty() ||
185 !m_finishedObservers.isEmpty(); 185 !m_finishedObservers.isEmpty();
186 } 186 }
187 void clear(); 187 void clear();
188 188
189 void createImage(); 189 void createImage();
190 void updateImage(bool allDataReceived); 190 void updateImage(bool allDataReceived);
191 void updateImageAndClearBuffer(); 191 void updateImageAndClearBuffer();
192 void clearImage(); 192 void clearImage();
193 enum NotifyFinishOption { ShouldNotifyFinish, DoNotNotifyFinish };
193 // If not null, changeRect is the changed part of the image. 194 // If not null, changeRect is the changed part of the image.
194 void notifyObservers(const IntRect* changeRect = nullptr); 195 void notifyObservers(NotifyFinishOption, const IntRect* changeRect = nullptr);
195 196
196 void ensureImage(); 197 void ensureImage();
197 198
198 void checkNotify() override; 199 void checkNotify() override;
199 void notifyObserversInternal(); 200 void notifyObserversInternal();
200 void markObserverFinished(ImageResourceObserver*); 201 void markObserverFinished(ImageResourceObserver*);
201 202
202 void doResetAnimation(); 203 void doResetAnimation();
203 204
204 void destroyDecodedDataIfPossible() override; 205 void destroyDecodedDataIfPossible() override;
(...skipping 26 matching lines...) Expand all
231 // Indicates if this resource's encoded image data can be purged and refetched 232 // Indicates if this resource's encoded image data can be purged and refetched
232 // from disk cache to save memory usage. See crbug/664437. 233 // from disk cache to save memory usage. See crbug/664437.
233 bool m_isRefetchableDataFromDiskCache; 234 bool m_isRefetchableDataFromDiskCache;
234 }; 235 };
235 236
236 DEFINE_RESOURCE_TYPE_CASTS(Image); 237 DEFINE_RESOURCE_TYPE_CASTS(Image);
237 238
238 } // namespace blink 239 } // namespace blink
239 240
240 #endif 241 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698