Chromium Code Reviews| Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc |
| diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc |
| index f5202d99cc40de4d1bdee5d6f817520b7c19d090..c53d44aefe1a1c75039e33069039c806f593489c 100644 |
| --- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc |
| +++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc |
| @@ -261,7 +261,7 @@ void ExtensionInstalledBubbleView::OnSignInLinkClicked() { |
| chrome::ShowBrowserSignin( |
| browser(), |
| signin_metrics::AccessPoint::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE); |
| - CloseBubble(); |
| + // Showing the sign-in UI will cause the bubble to close. |
|
Devlin
2016/11/02 18:12:23
Does this happen synchronously? If so, can we CHE
Evan Stade
2016/11/02 22:57:19
Done.
|
| } |
| void ExtensionInstalledBubbleView::LinkClicked(views::Link* source, |
| @@ -273,7 +273,7 @@ void ExtensionInstalledBubbleView::LinkClicked(views::Link* source, |
| chrome::NavigateParams params( |
| chrome::GetSingletonTabNavigateParams(browser(), GURL(configure_url))); |
| chrome::Navigate(¶ms); |
| - CloseBubble(); |
| + // Navigating will cause the bubble to close. |
| } |
| gfx::Size ExtensionInstalledBubbleView::GetIconSize() const { |