Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2468853002: Do not kill renderer when enumerateDevices is called from about:blank. (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org, hta - Chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not kill renderer when enumerateDevices is called from unique origins (e.g., about:blank). This CL restores the behavior of enumerateDevices with unique origins before the Mojo migration. BUG=660204 Committed: https://crrev.com/7ab0eddda935e0f3bf84d73d7806c9f1d5fccd99 Cr-Commit-Position: refs/heads/master@{#431090}

Patch Set 1 #

Patch Set 2 : Do not kill renderer when enumerateDevices is called from about:blank. #

Patch Set 3 : Add test #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M content/browser/renderer_host/media/media_devices_dispatcher_host.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 27 (14 generated)
Guido Urdaneta
mkwst@: please review this change to IPC parameter validation. See http://crbug.com/660204 for more context.
4 years, 1 month ago (2016-11-01 10:22:46 UTC) #4
Mike West
Can you add a test that doesn't crash? :)
4 years, 1 month ago (2016-11-03 13:05:33 UTC) #5
Guido Urdaneta
On 2016/11/03 13:05:33, Mike West wrote: > Can you add a test that doesn't crash? ...
4 years, 1 month ago (2016-11-03 16:51:31 UTC) #8
Mike West
LGTM, thanks!
4 years, 1 month ago (2016-11-07 09:54:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468853002/80001
4 years, 1 month ago (2016-11-07 09:56:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/298349)
4 years, 1 month ago (2016-11-07 10:02:58 UTC) #13
Guido Urdaneta
tommi@: PTAL
4 years, 1 month ago (2016-11-07 10:27:24 UTC) #15
tommi (sloooow) - chröme
lgtm
4 years, 1 month ago (2016-11-09 13:13:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468853002/80001
4 years, 1 month ago (2016-11-09 20:28:24 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/102758) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-09 20:32:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468853002/100001
4 years, 1 month ago (2016-11-09 22:23:41 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 1 month ago (2016-11-10 00:09:32 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:20:19 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7ab0eddda935e0f3bf84d73d7806c9f1d5fccd99
Cr-Commit-Position: refs/heads/master@{#431090}

Powered by Google App Engine
This is Rietveld 408576698