Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2468833002: Count visible password fields on a page (Closed)
Patch Set: dcheng comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 499dc191a10340316822298111befac43d9dc795..493384977d5f62767cf4b6ddfedf24b6246de217 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -211,6 +211,13 @@ void ContentPasswordManagerDriver::PasswordFieldVisibleInInsecureContext() {
MaybeNotifyPasswordInputShownOnHttp(render_frame_host_);
}
+void ContentPasswordManagerDriver::
+ AllPasswordFieldsInInsecureContextInvisible() {
+ // TODO(estark): if all frames in the frame tree have their password
+ // fields hidden, then notify the WebContents that there are no
+ // visible password fields left. https://crbug.com/658764
+}
+
void ContentPasswordManagerDriver::DidNavigateFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {

Powered by Google App Engine
This is Rietveld 408576698