third_party/inspector_protocol/CodeGenerator.py - Issue 2468803002: [DevTools] migrate InspectorDOMAgent to new style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/inspector_protocol/CodeGenerator.py

Issue 2468803002: [DevTools] migrate InspectorDOMAgent to new style (Closed)

Patch Set: addressed comments and rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/inspector_protocol/CodeGenerator.py

diff --git a/third_party/inspector_protocol/CodeGenerator.py b/third_party/inspector_protocol/CodeGenerator.py

index a668361e7f71fa5e5f83798b8c64272397f16468..d5f6971835f6cb8b4a08d29e1c68d68f577f0150 100644

--- a/third_party/inspector_protocol/CodeGenerator.py

+++ b/third_party/inspector_protocol/CodeGenerator.py

@@ -330,7 +330,7 @@ def resolve_type(protocol, prop):

def new_style(domain):

- domains = ["DOMStorage", "Rendering", "Emulation", "Network", "Memory", "Page", "LayerTree", "Database", "IndexedDB", "CacheStorage" ]

+ domains = ["DOMStorage", "Rendering", "Emulation", "Network", "Memory", "Page", "LayerTree", "Database", "IndexedDB", "CacheStorage", "DOM" ]

return domain["domain"] in domains