Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: third_party/WebKit/Source/core/inspector/DOMEditor.h

Issue 2468803002: [DevTools] migrate InspectorDOMAgent to new style (Closed)
Patch Set: addressed comments and rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/DOMEditor.h
diff --git a/third_party/WebKit/Source/core/inspector/DOMEditor.h b/third_party/WebKit/Source/core/inspector/DOMEditor.h
index 8e0e260d19e40f53ebfe6f1ac0db20405247b80d..28cb1dcdb5cb8d78773f7018ba5bf84c4efbd067 100644
--- a/third_party/WebKit/Source/core/inspector/DOMEditor.h
+++ b/third_party/WebKit/Source/core/inspector/DOMEditor.h
@@ -43,8 +43,7 @@ class ExceptionState;
class InspectorHistory;
class Node;
class Text;
-
-using protocol::ErrorString;
+using protocol::Response;
class DOMEditor final : public GarbageCollected<DOMEditor> {
WTF_MAKE_NONCOPYABLE(DOMEditor);
@@ -72,18 +71,12 @@ class DOMEditor final : public GarbageCollected<DOMEditor> {
ExceptionState&);
bool setNodeValue(Node* parentNode, const String& value, ExceptionState&);
- bool insertBefore(ContainerNode* parentNode,
- Node*,
- Node* anchorNode,
- ErrorString*);
- bool removeChild(ContainerNode* parentNode, Node*, ErrorString*);
- bool setAttribute(Element*,
- const String& name,
- const String& value,
- ErrorString*);
- bool removeAttribute(Element*, const String& name, ErrorString*);
- bool setOuterHTML(Node*, const String& html, Node** newNode, ErrorString*);
- bool replaceWholeText(Text*, const String& text, ErrorString*);
+ Response insertBefore(ContainerNode* parentNode, Node*, Node* anchorNode);
+ Response removeChild(ContainerNode* parentNode, Node*);
+ Response setAttribute(Element*, const String& name, const String& value);
+ Response removeAttribute(Element*, const String& name);
+ Response setOuterHTML(Node*, const String& html, Node** newNode);
+ Response replaceWholeText(Text*, const String& text);
private:
class DOMAction;
« no previous file with comments | « ash/common/devtools/ash_devtools_dom_agent.cc ('k') | third_party/WebKit/Source/core/inspector/DOMEditor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698