Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2468743002: TEMPORARY: track stencil clip state in GrRenderTargetOpList (Closed)

Created:
4 years, 1 month ago by csmartdalton
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

TEMPORARY: track stencil clip state in GrRenderTargetOpList Tracks the stencil clip state in GrRenderTargetOpList instead of GrStencilAttachment. This is a temporary move to unblock MDB, after which point we will be able to overhaul clipping. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468743002 Committed: https://skia.googlesource.com/skia/+/7cdda99ac34dbe249640be04d2e61bfb0f4b3b09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M src/gpu/GrClipStackClip.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M src/gpu/GrRenderTargetContextPriv.h View 1 chunk +22 lines, -0 lines 0 comments Download
M src/gpu/GrRenderTargetOpList.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/GrRenderTargetOpList.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrStencilAttachment.h View 3 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 1 month ago (2016-10-31 22:39:32 UTC) #3
bsalomon
lgtm
4 years, 1 month ago (2016-11-01 13:24:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468743002/1
4 years, 1 month ago (2016-11-01 13:42:59 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 14:03:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7cdda99ac34dbe249640be04d2e61bfb0f4b3b09

Powered by Google App Engine
This is Rietveld 408576698