Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2468723003: Move session service and supervised users to buildflags. (Closed)

Created:
4 years, 1 month ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
sky, Dan Beam
CC:
chromium-reviews, msramek+watch_chromium.org, skanuj+watch_chromium.org, sadrul, dhollowa+watch_chromium.org, dougw+watch_chromium.org, rginda+watch_chromium.org, markusheintz_, extensions-reviews_chromium.org, melevin+watch_chromium.org, raymes+watch_chromium.org, Patrick Dubroy, Jered, loading-reviews_chromium.org, kalyank, dbeam+watch-options_chromium.org, Randy Smith (Not in Mondays), jfweitz+watch_chromium.org, pam+watch_chromium.org, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org, michaelpg+watch-options_chromium.org, donnd+watch_chromium.org, dbeam+watch-history_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move session service and supervised users to buildflags. The session service and supervised user flags used to be global build variables and defines. This patch converts them to use the buildflag system to clean up the dependencies and scope the feature. R=sky TBR=dbeam (webui owners) Committed: https://crrev.com/9e85ef482ba591482edac786d101d8d37cf4b451 Cr-Commit-Position: refs/heads/master@{#429107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -154 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_factory.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_sync_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/lifetime/browser_close_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/avatar_menu.h View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/profiles/avatar_menu.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/search/search.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/chrome_tab_restore_service_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_tab_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_users.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/supervised_user_signin_manager_wrapper.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_properties.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_service.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.h View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 13 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/md_user_manager_ui.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/md_user_manager_ui.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.h View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/features.gni View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
brettw
4 years, 1 month ago (2016-10-31 21:55:08 UTC) #2
sky
LGTM
4 years, 1 month ago (2016-10-31 22:33:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468723003/1
4 years, 1 month ago (2016-11-01 17:20:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/294173)
4 years, 1 month ago (2016-11-01 17:28:23 UTC) #11
brettw
4 years, 1 month ago (2016-11-01 20:44:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468723003/1
4 years, 1 month ago (2016-11-01 20:45:29 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e85ef482ba591482edac786d101d8d37cf4b451 Cr-Commit-Position: refs/heads/master@{#429107}
4 years, 1 month ago (2016-11-01 21:04:05 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 21:04:12 UTC) #19
Message was sent while issue was closed.
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698