Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2468723002: Re-land "Change FX_BOOL definition from int to bool. (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Re-land "Change FX_BOOL definition from int to bool." This reverts commit 747dcf7 Committed: https://pdfium.googlesource.com/pdfium/+/5a22582ca1dbe1d66b18d5253bfa1d202fcc3b4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M core/fxcrt/fx_system.h View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Lei, try #2.
4 years, 1 month ago (2016-10-31 21:46:57 UTC) #5
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-31 21:55:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468723002/1
4 years, 1 month ago (2016-10-31 21:56:52 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 21:59:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5a22582ca1dbe1d66b18d5253bfa1d202fcc...

Powered by Google App Engine
This is Rietveld 408576698