Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2468673003: [Extensions] Remove ExtensionWebUI (Closed)
Patch Set: nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index d70b2fede1d6e1f5f56d75514e6bde0dc0253a8f..939cb7d0fad36708da05034fe8bb682d361e331d 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1213,10 +1213,14 @@ bool ChromeContentBrowserClient::ShouldAllowOpenURL(
return true;
}
-void ChromeContentBrowserClient::OverrideOpenURLParams(
- content::SiteInstance* site_instance,
- content::OpenURLParams* params) {
- DCHECK(params);
+void ChromeContentBrowserClient::OverrideNavigationParams(
+ SiteInstance* site_instance,
+ ui::PageTransition* transition,
+ bool* is_renderer_initiated,
+ content::Referrer* referrer) {
+ DCHECK(transition);
+ DCHECK(is_renderer_initiated);
+ DCHECK(referrer);
// TODO(crbug.com/624410): Factor the predicate to identify a URL as an NTP
// to a shared library.
if (site_instance &&
@@ -1225,14 +1229,18 @@ void ChromeContentBrowserClient::OverrideOpenURLParams(
chrome::kChromeSearchRemoteNtpHost ||
site_instance->GetSiteURL().host() ==
chrome::kChromeSearchLocalNtpHost) &&
- ui::PageTransitionCoreTypeIs(params->transition,
- ui::PAGE_TRANSITION_LINK)) {
+ ui::PageTransitionCoreTypeIs(*transition, ui::PAGE_TRANSITION_LINK)) {
// Use AUTO_BOOKMARK for clicks on tiles of the new tab page, consistently
// with native implementations like Android's.
- params->transition = ui::PAGE_TRANSITION_AUTO_BOOKMARK;
- params->is_renderer_initiated = false;
- params->referrer = content::Referrer();
+ *transition = ui::PAGE_TRANSITION_AUTO_BOOKMARK;
+ *is_renderer_initiated = false;
+ *referrer = content::Referrer();
}
+
+#if defined(ENABLE_EXTENSIONS)
+ ChromeContentBrowserClientExtensionsPart::OverrideNavigationParams(
+ site_instance, transition, is_renderer_initiated, referrer);
+#endif
}
bool ChromeContentBrowserClient::IsSuitableHost(

Powered by Google App Engine
This is Rietveld 408576698