[Extensions] Remove ExtensionWebUI

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 748 matching lines @@
   params.uses_post = uses_post;
   params.post_data = body;
   params.extra_headers = extra_headers;
   params.source_site_instance = source_site_instance;
   if (redirect_chain.size() > 0)
     params.redirect_chain = redirect_chain;
   params.should_replace_current_entry = should_replace_current_entry;
   params.user_gesture = user_gesture;
 
   if (render_frame_host->web_ui()) {
-    // Web UI pages sometimes want to override the page transition type for
-    // link clicks (e.g., so the new tab page can specify AUTO_BOOKMARK for
-    // automatically generated suggestions).  We don't override other types
-    // like TYPED because they have different implications (e.g., autocomplete).
-    if (ui::PageTransitionCoreTypeIs(
-        params.transition, ui::PAGE_TRANSITION_LINK))
-      params.transition = render_frame_host->web_ui()->GetLinkTransitionType();

[Charlie Reis, 2016/11/04 23:31:59]

Sanity check: No other actual WebUI pages rely on this?  I see the NTP is
mentioned here, but that got switched away from WebUI quite some time ago.  If
not, I'm thrilled to remove some of this complexity.

[Devlin, 2016/11/05 01:23:17]

No other WebUI ever sets a transition type (and the default value is set to
link) and no tests fail, so I'm pretty sure not.

-
-    // Note also that we hide the referrer for Web UI pages. We don't really
-    // want web sites to see a referrer of "chrome://blah" (and some
-    // chrome: URLs might have search terms or other stuff we don't want to
-    // send to the site), so we send no referrer.
+    // Note that we hide the referrer for Web UI pages. We don't really want
+    // web sites to see a referrer of "chrome://blah" (and some chrome: URLs
+    // might have search terms or other stuff we don't want to send to the
+    // site), so we send no referrer.
     params.referrer = Referrer();
 
     // Navigations in Web UI pages count as browser-initiated navigations.
     params.is_renderer_initiated = false;
   }
 
   GetContentClient()->browser()->OverrideOpenURLParams(current_site_instance,
                                                        &params);
 
   if (delegate_)
     delegate_->RequestOpenURL(render_frame_host, params);
 }
 
 void NavigatorImpl::RequestTransferURL(

[Devlin, 2016/11/02 22:01:43]

There's no ContentBrowserClient::OverrideTransferURL-type method, so we lose the
ability to update the transition type and set the referer here.  Any
suggestions?  Would a new method on ContentBrowserClient be the way to go,
or...?

[Charlie Reis, 2016/11/04 23:31:59]

Interesting.  It would be nice to unify these if possible.  The only current
implementation of OverrideOpenURLParams is for exactly this behavior (for the
NTP).  I wonder if we should rename it to OverrideNavigationParams and pass in
references to transition, is_renderer_initiated, and referrer.  Then we could
call it from both RequestOpenURL and RequestTransferURL, and support the NTP,
bookmarks, and other extension cases.

It's a bit less general purpose for the RequestOpenURLParams case, but I think
that may be ok.  Thoughts?

[Devlin, 2016/11/05 01:23:17]

Sounds good to me!  Done.

     RenderFrameHostImpl* render_frame_host,
     const GURL& url,
     SiteInstance* source_site_instance,
     const std::vector<GURL>& redirect_chain,
     const Referrer& referrer,
     ui::PageTransition page_transition,
     const GlobalRequestID& transferred_global_request_id,
     bool should_replace_current_entry,
     const std::string& method,
     scoped_refptr<ResourceRequestBodyImpl> post_body,
@@ skipping 19 matching lines @@
   SiteInstance* current_site_instance = render_frame_host->GetSiteInstance();
   if (!GetContentClient()->browser()->ShouldAllowOpenURL(current_site_instance,
                                                          url)) {
     dest_url = GURL(url::kAboutBlankURL);
   }
 
   // TODO(creis): Determine if this transfer started as a browser-initiated
   // navigation.  See https://crbug.com/495161.
   bool is_renderer_initiated = true;
   if (render_frame_host->web_ui()) {
-    // Web UI pages sometimes want to override the page transition type for
-    // link clicks (e.g., so the new tab page can specify AUTO_BOOKMARK for
-    // automatically generated suggestions).  We don't override other types
-    // like TYPED because they have different implications (e.g., autocomplete).
-    if (ui::PageTransitionCoreTypeIs(page_transition, ui::PAGE_TRANSITION_LINK))
-      page_transition = render_frame_host->web_ui()->GetLinkTransitionType();
-
-    // Note also that we hide the referrer for Web UI pages. We don't really
-    // want web sites to see a referrer of "chrome://blah" (and some
-    // chrome: URLs might have search terms or other stuff we don't want to
-    // send to the site), so we send no referrer.
+    // Note that we hide the referrer for Web UI pages. We don't really want
+    // web sites to see a referrer of "chrome://blah" (and some chrome: URLs
+    // might have search terms or other stuff we don't want to send to the
+    // site), so we send no referrer.
     referrer_to_use = Referrer();
 
     // Navigations in Web UI pages count as browser-initiated navigations.
     is_renderer_initiated = false;
   }
 
   // Create a NavigationEntry for the transfer, without making it the pending
   // entry.  Subframe transfers should only be possible in OOPIF-enabled modes,
   // and should have a clone of the last committed entry with a
   // FrameNavigationEntry for the target frame.  Main frame transfers should
@@ skipping 406 matching lines @@
     if (navigation_handle)
       navigation_handle->update_entry_id_for_transfer(entry->GetUniqueID());
 
     controller_->SetPendingEntry(std::move(entry));
     if (delegate_)
       delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);
   }
 }
 
 }  // namespace content