Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2468653003: Add some device-related interfaces that were missing from the manifest (Closed)

Created:
4 years, 1 month ago by Ben Goodger (Google)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some device-related interfaces that were missing from the manifest R=rockot@chromium.org,tsepez@chromium.org BUG= Committed: https://crrev.com/84bb1677c5bc6d75ba0fcf6aa0990bc8e938e977 Cr-Commit-Position: refs/heads/master@{#428866}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M android_webview/browser/aw_browser_manifest_overlay.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_manifest_overlay.json View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Ben Goodger (Google)
4 years, 1 month ago (2016-10-31 22:35:17 UTC) #1
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-10-31 22:45:07 UTC) #4
Tom Sepez
lgtm
4 years, 1 month ago (2016-10-31 22:46:21 UTC) #5
Tom Sepez
still lgtm
4 years, 1 month ago (2016-10-31 22:50:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468653003/20001
4 years, 1 month ago (2016-10-31 22:50:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 23:40:04 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 23:42:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84bb1677c5bc6d75ba0fcf6aa0990bc8e938e977
Cr-Commit-Position: refs/heads/master@{#428866}

Powered by Google App Engine
This is Rietveld 408576698