Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2468633003: Allow inherited constructors and add a sample usage. (Closed)

Created:
4 years, 1 month ago by Peter Kasting
Modified:
4 years, 1 month ago
Reviewers:
brettw, jbroman
CC:
agrieve+watch_chromium.org, chromium-reviews, danakj+watch_chromium.org, Dirk Pranke, jbroman+cpp_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow inherited constructors and add a sample usage. This was OKed on the discussion thread back in July, but never added. BUG=none TEST=none Committed: https://crrev.com/3e35c53fdc3e68aa70efbca7f49a8494df79db1b Cr-Commit-Position: refs/heads/master@{#429716}

Patch Set 1 #

Patch Set 2 : Resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M styleguide/c++/c++11.html View 1 2 chunks +10 lines, -10 lines 0 comments Download
M tools/gn/pool.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/pool.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
Peter Kasting
brettw: tools/gn thakis: styleguide
4 years, 1 month ago (2016-11-01 00:18:16 UTC) #2
brettw
I didn't even know this was a thing. LGTM
4 years, 1 month ago (2016-11-01 22:44:09 UTC) #7
Peter Kasting
ping thakis
4 years, 1 month ago (2016-11-02 20:46:58 UTC) #8
Peter Kasting
Changing to jbroman since Nico's status is "mostly AFK".
4 years, 1 month ago (2016-11-03 22:09:13 UTC) #16
jbroman
styleguide/c++/ lgtm
4 years, 1 month ago (2016-11-03 22:26:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468633003/20001
4 years, 1 month ago (2016-11-03 22:30:53 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 22:54:46 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 22:56:35 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e35c53fdc3e68aa70efbca7f49a8494df79db1b
Cr-Commit-Position: refs/heads/master@{#429716}

Powered by Google App Engine
This is Rietveld 408576698