Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c9bab2153937afee58c5e9f467c1c4160e575cb6
Cr-Commit-Position: refs/heads/master@{#431315}

[Alex Z., 2016-10-31 19:14:52]

Description was changed from

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
==========

to

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Alex Z., 2016-10-31 19:14:57]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:15:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2016-10-31 19:21:07]

staraz@chromium.org changed reviewers:
+ dtrainor@chromium.org, fsamuel@chromium.org, piman@chromium.org

[Alex Z., 2016-10-31 19:21:07]

dtrainor@chromium.org: Please review changes under blimp/

fsamuel@chromium.org: Please review my changes. This CL corresponds to the 2nd
point of your bug 655639 

piman@chromium.org: Please review changes under cc/ and ui/compositor/

[commit-bot: I haz the power, 2016-10-31 19:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:34:58]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Alex Z., 2016-10-31 20:21:26]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 20:22:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:40:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:40:19]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[piman, 2016-10-31 21:15:50]

lgtm % compile fixes

[Fady Samuel, 2016-11-01 02:28:27]

lgtm + nit.

https://codereview.chromium.org/2468633002/diff/20001/cc/surfaces/display.cc
File cc/surfaces/display.cc (right):

https://codereview.chromium.org/2468633002/diff/20001/cc/surfaces/display.cc#...
cc/surfaces/display.cc:108: device_scale_factor_ == device_scale_factor)
nit: add braces

[David Trainor- moved to gerrit, 2016-11-02 16:46:26]

blimp/ lgtm

[Alex Z., 2016-11-09 16:35:38]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 16:35:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 16:46:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 16:46:30]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[Alex Z., 2016-11-09 17:00:18]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 17:00:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 17:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 17:16:18]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Alex Z., 2016-11-09 18:48:34]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 18:48:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 19:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 19:09:09]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alex Z., 2016-11-09 19:26:15]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2016-11-09 19:26:50]

staraz@chromium.org changed reviewers:
+ michaelbai@chromium.org

[commit-bot: I haz the power, 2016-11-09 19:26:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2016-11-09 19:26:51]

michaelbai@chromium.org: Please review changes in
android_webview/browser/surfaces_instance.cc

https://codereview.chromium.org/2468633002/diff/20001/cc/surfaces/display.cc
File cc/surfaces/display.cc (right):

https://codereview.chromium.org/2468633002/diff/20001/cc/surfaces/display.cc#...
cc/surfaces/display.cc:108: device_scale_factor_ == device_scale_factor)
On 2016/11/01 02:28:27, Fady Samuel wrote:
> nit: add braces

Done.

[commit-bot: I haz the power, 2016-11-09 20:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 20:22:29]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-11-09 21:24:47]

You'll likely need to rebase this patch now that your other patch has landed.

[Alex Z., 2016-11-09 22:07:43]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 22:08:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 22:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 22:21:02]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[michaelbai, 2016-11-09 23:03:31]

Description was changed from

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[michaelbai, 2016-11-09 23:03:31]

michaelbai@chromium.org changed reviewers:
+ boliu@chromium.org

[michaelbai, 2016-11-09 23:03:53]

add boliu@ for WebView

[Alex Z., 2016-11-10 18:15:13]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 18:15:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-11-10 18:47:35]

lgtm

[commit-bot: I haz the power, 2016-11-10 19:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 19:16:40]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2016-11-10 19:22:14]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2016-11-10 19:22:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, dtrainor@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2468633002/#ps140001
(title: "rebase and minor bug fixes")

[commit-bot: I haz the power, 2016-11-10 19:22:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 19:28:08]

Description was changed from

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-11-10 19:28:10]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-10 19:40:30]

Description was changed from

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Replaced cc::Display::SetSurfaceId() with SetLocalFrameId()

Display's FrameSinkId should never change. Therefore, the field is set to const
and is now set in the constructor rather than Initialize().

BUG=656639
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c9bab2153937afee58c5e9f467c1c4160e575cb6
Cr-Commit-Position: refs/heads/master@{#431315}
==========

[commit-bot: I haz the power, 2016-11-10 19:40:32]

Patchset 8 (id:??) landed as
https://crrev.com/c9bab2153937afee58c5e9f467c1c4160e575cb6
Cr-Commit-Position: refs/heads/master@{#431315}