Issue 246863004: WIP initial sketch for an Android GCMClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246863004: WIP initial sketch for an Android GCMClient (Closed)

Created:
6 years, 8 months ago by johnme

Modified:
6 years, 7 months ago

Reviewers:
Dmitry Titov, fgorski

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[DO NOT SUBMIT] WIP initial sketch for an Android GCMClient Draft of how GCMClient might have an alternate Android implementation. This is an early work-in-progress, and is not ready to submit. BUG=350384

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+280 lines, -0 lines)			Patch
M	chrome/browser/services/gcm/gcm_client_factory.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	google_apis/gcm/gcm.gyp	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	google_apis/gcm/gcm_client_impl_android.h	View	1 chunk	+88 lines, -0 lines	0 comments	Download
A	google_apis/gcm/gcm_client_impl_android.cc	View	1 chunk	+174 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

johnme

fgorski & dimich: Would you mind giving your initial thoughts on whether this is the ...

6 years, 8 months ago (2014-04-22 18:26:32 UTC) #1

johnme

6 years, 7 months ago (2014-05-16 10:16:38 UTC) #2

Message was sent while issue was closed.

Abandoning this patch in favour of https://codereview.chromium.org/278493002

For full context on the refactoring plans, see
https://docs.google.com/a/google.com/document/d/1R3B7TMRYyICTTGIOj_09A5d7iyyX...

Expand Messages | Collapse Messages