Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2468593002:
Fix undefined behavior in UnixDomainSocketUtil.Connect test. (Closed)
DescriptionFix undefined behavior in UnixDomainSocketUtil.Connect test.
After SocketAcceptor is destructed, the thread might still have been
attached to it, and an invalid cast on the already destructed object
was performed.
This bug was found under UBSan.
BUG=660174
Committed: https://crrev.com/49c519ecea2ee0d83d0faf76b5f7c4cc2a92b0e0
Cr-Commit-Position: refs/heads/master@{#429085}
Patch Set 1 #Patch Set 2 : run ipc_tests on UBSan buildbots. #
Messages
Total messages: 26 (14 generated)
krasin@chromium.org changed reviewers: + jam@chromium.org
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jam@chromium.org changed reviewers: + tsepez@chromium.org
Switching reviewers to Tom; I'm not really familiar with this.
Description was changed from ========== Fix undefined behavior in UnixDomainSocketUtil.Connect test. After SocketAcceptor is destructed, the thread might still have been attached to it, and an invalid cast on the already destructed object was performed. This bug was found under UBSan. BUG=660174 ========== to ========== Fix undefined behavior in UnixDomainSocketUtil.Connect test. After SocketAcceptor is destructed, the thread might still have been attached to it, and an invalid cast on the already destructed object was performed. This bug was found under UBSan. BUG=660174 ==========
jam@chromium.org changed reviewers: - jam@chromium.org
lgtm I'm not that familiar either, but I do think this solves the race.
On 2016/11/01 18:28:36, Tom Sepez wrote: > lgtm > > I'm not that familiar either, but I do think this solves the race. Thank you, Tom!
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
krasin@chromium.org changed reviewers: + dpranke@chromium.org
Hi Dirk, please, approve another small change to chromium.fyi.json.
lgtm
The CQ bit was checked by krasin@chromium.org
On 2016/11/01 19:09:56, Dirk Pranke wrote: > lgtm Thank you, Dirk!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix undefined behavior in UnixDomainSocketUtil.Connect test. After SocketAcceptor is destructed, the thread might still have been attached to it, and an invalid cast on the already destructed object was performed. This bug was found under UBSan. BUG=660174 ========== to ========== Fix undefined behavior in UnixDomainSocketUtil.Connect test. After SocketAcceptor is destructed, the thread might still have been attached to it, and an invalid cast on the already destructed object was performed. This bug was found under UBSan. BUG=660174 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix undefined behavior in UnixDomainSocketUtil.Connect test. After SocketAcceptor is destructed, the thread might still have been attached to it, and an invalid cast on the already destructed object was performed. This bug was found under UBSan. BUG=660174 ========== to ========== Fix undefined behavior in UnixDomainSocketUtil.Connect test. After SocketAcceptor is destructed, the thread might still have been attached to it, and an invalid cast on the already destructed object was performed. This bug was found under UBSan. BUG=660174 Committed: https://crrev.com/49c519ecea2ee0d83d0faf76b5f7c4cc2a92b0e0 Cr-Commit-Position: refs/heads/master@{#429085} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/49c519ecea2ee0d83d0faf76b5f7c4cc2a92b0e0 Cr-Commit-Position: refs/heads/master@{#429085} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
