Issue 2468583002: Explain why we need SourceFactory.clone(). - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(146)

My Issues | Starred Open | Closed | All

Issue 2468583002: Explain why we need SourceFactory.clone(). (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Explain why we need SourceFactory.clone(). R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ba382b6ce43f136a3e6e64511cd12de5bda2297b

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as ba382b6ce43f136a3e6e64511cd12de5bda2297b (presubmit successful).

4 years, 1 month ago (2016-10-31 19:18:50 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698