| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 45 # (best effort). | 45 # (best effort). |
| 46 _TEST_CODE_EXCLUDED_PATHS = ( | 46 _TEST_CODE_EXCLUDED_PATHS = ( |
| 47 r'.*[\\\/](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS, | 47 r'.*[\\\/](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS, |
| 48 r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS, | 48 r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS, |
| 49 r'.+_(api|browser|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % | 49 r'.+_(api|browser|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % |
| 50 _IMPLEMENTATION_EXTENSIONS, | 50 _IMPLEMENTATION_EXTENSIONS, |
| 51 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS, | 51 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS, |
| 52 r'.*[\\\/](test|tool(s)?)[\\\/].*', | 52 r'.*[\\\/](test|tool(s)?)[\\\/].*', |
| 53 # content_shell is used for running layout tests. | 53 # content_shell is used for running layout tests. |
| 54 r'content[\\\/]shell[\\\/].*', | 54 r'content[\\\/]shell[\\\/].*', |
| 55 # At request of folks maintaining this folder. | |
| 56 r'chrome[\\\/]browser[\\\/]automation[\\\/].*', | |
| 57 # Non-production example code. | 55 # Non-production example code. |
| 58 r'mojo[\\\/]examples[\\\/].*', | 56 r'mojo[\\\/]examples[\\\/].*', |
| 59 # Launcher for running iOS tests on the simulator. | 57 # Launcher for running iOS tests on the simulator. |
| 60 r'testing[\\\/]iossim[\\\/]iossim\.mm$', | 58 r'testing[\\\/]iossim[\\\/]iossim\.mm$', |
| 61 ) | 59 ) |
| 62 | 60 |
| 63 | 61 |
| 64 _TEST_ONLY_WARNING = ( | 62 _TEST_ONLY_WARNING = ( |
| 65 'You might be calling functions intended only for testing from\n' | 63 'You might be calling functions intended only for testing from\n' |
| 66 'production code. It is OK to ignore this warning if you know what\n' | 64 'production code. It is OK to ignore this warning if you know what\n' |
| (...skipping 2233 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 2300 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 2298 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 2301 input_api, | 2299 input_api, |
| 2302 output_api, | 2300 output_api, |
| 2303 json_url='http://chromium-status.appspot.com/current?format=json')) | 2301 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2304 | 2302 |
| 2305 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2303 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2306 input_api, output_api)) | 2304 input_api, output_api)) |
| 2307 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2305 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2308 input_api, output_api)) | 2306 input_api, output_api)) |
| 2309 return results | 2307 return results |
| OLD | NEW |